cross-platform issue with experimental version numbers #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imental version numbers
|
This pull request has been linked to Shortcut Story #19946: experimental version numbers, parse_uri/get_fragment_name_version xplat sizeof(long)/stol() issue. |
bekadavis9
approved these changes
Aug 2, 2022
ihnorton
added a commit
that referenced
this pull request
Aug 3, 2022
commit 1ca162835ac614defe19dd440319a81c912a27b0
Author: Isaiah Norton <isaiah@tiledb.io>
Date: Tue Aug 2 23:20:02 2022 -0400
Update
commit 90f4b95
Author: dhoke4tdb <78012908+dhoke4tdb@users.noreply.github.com>
Date: Tue Aug 2 21:13:33 2022 -0400
change stol() to stoul() for correct cross-platform issues with experimental version numbers (#3410)
Change stol() to stoul() for correct cross-platform operations with experimental version numbers.
TYPE: BUG
DESC: use stoul() to correctly parse (32bit unsigned values) experimental version numbers cross-platform
commit bf465c3
Author: Isaiah Norton <isaiah@tiledb.io>
Date: Tue Aug 2 08:51:18 2022 -0400
Fix whitespace (unrelated to PR)
commit ed40669
Author: Isaiah Norton <isaiah@tiledb.io>
Date: Tue Aug 2 08:49:01 2022 -0400
Validate Dimension Datatype upon Dimension construction
Now that Dimension is C.41 compliant, the constructor must take on the responsibility of validation. A new API has been added that validates the incoming Datatype for Dimensions, disallowing certain types.
---
SC-17968
---
TYPE: IMPROVEMENT
DESC: Validate Dimension datatype
commit d48f874
Author: dhoke4tdb <78012908+dhoke4tdb@users.noreply.github.com>
Date: Tue Aug 2 08:11:16 2022 -0400
add tdb_catch.h wrapper for catch.hpp (#3390)
* add tdb_catch.h wrapper to aid transition to new/mixed catch2/3 versions in build environments
* locate tdb_catch.h in test/support (a new [sub-]directory)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change stol() to stoul() for correct cross-platform operations with experimental version numbers
TYPE: BUG
DESC: use stoul() to correctly parse (32bit unsigned values) experimental version numbers cross-platform