Enable building libcurl with zstd support #3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #20681: Support zstd for curl http compression. |
This adds support for curl to enable zstd compression in linux/macos builds. Windows uses cmake for building and the curl cmake does not allow for setting the library paths for zstd. This means the windows superbuild is not supported. For now we just enable on linux/macos. The goal of enable zstd to is to allow this as an option for http compression.
Shelnutt2
force-pushed
the
sethshelnutt/sc-20681/support-zstd-for-curl-http-compression
branch
from
363d1f1
to
e47ab64
Compare
ihnorton
approved these changes
Aug 22, 2022
robertbindar
approved these changes
Aug 22, 2022
Shelnutt2
force-pushed
the
sethshelnutt/sc-20681/support-zstd-for-curl-http-compression
branch
from
e86d656
to
9d3ec7b
Compare
ihnorton
approved these changes
Aug 22, 2022
ihnorton
deleted the
sethshelnutt/sc-20681/support-zstd-for-curl-http-compression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for curl to enable zstd compression in linux/macos builds. Windows uses cmake for building and the curl cmake does not allow for setting the library paths for zstd. This means the windows superbuild is not supported. For now we just enable on linux/macos.
The goal of enable zstd to is to allow this as an option for http compression.
TYPE: IMPROVEMENT
DESC: Enable superbuild libcurl to support zstd