Sparse global order reader: incomplete reads when hitting memory limits. #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we cannot load all tiles in the result cell slabs in memory for a specific attribute, we truncate the result cell slabs so that it fits. When doing this, we have to revert progress in the indexes so that the continuation picks up those tiles again. --- TYPE: BUG DESC: Sparse global order reader: incomplete reads when hitting memory limits.
Shelnutt2
approved these changes
Sep 16, 2022
@Shelnutt2 I'll make one tomorrow. If you want to merge this before, it's fine, I'll file a follow up ticket. |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2022
…ts. (#3518) * Sparse global order reader: incomplete reads when hitting memory limits. When we cannot load all tiles in the result cell slabs in memory for a specific attribute, we truncate the result cell slabs so that it fits. When doing this, we have to revert progress in the indexes so that the continuation picks up those tiles again. --- TYPE: BUG DESC: Sparse global order reader: incomplete reads when hitting memory limits. * Adding unit test.
ihnorton
pushed a commit
that referenced
this pull request
Sep 16, 2022
…ts. (#3518) (#3519) * Sparse global order reader: incomplete reads when hitting memory limits. When we cannot load all tiles in the result cell slabs in memory for a specific attribute, we truncate the result cell slabs so that it fits. When doing this, we have to revert progress in the indexes so that the continuation picks up those tiles again. --- TYPE: BUG DESC: Sparse global order reader: incomplete reads when hitting memory limits. * Adding unit test. Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we cannot load all tiles in the result cell slabs in memory for a specific attribute, we truncate the result cell slabs so that it fits. When doing this, we have to revert progress in the indexes so that the continuation picks up those tiles again.
TYPE: BUG
DESC: Sparse global order reader: incomplete reads when hitting memory limits.