New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip fragments missing new attribute after evolution #3528
Conversation
This pull request has been linked to Shortcut Story #21652: Segfault after schema evolution. |
+ Will revert this commit before merge
The segmentation fault is no longer occurring, but I'm now noticing fill values are not applied to the final read in the example I pushed in the latest commit. To summarize, I evolve the schema here
And later read from the array after writing
But I would expect the output to be
Any advice would be appreciated |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.11 release-2.11
# Navigate to the new working tree
cd .worktrees/backport-release-2.11
# Create a new branch
git switch --create backport-3528-to-release-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 a7f385e6d27cb236afd9b63b3d3290e2f66cf2dd
# Push it to GitHub
git push --set-upstream origin backport-3528-to-release-2.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.11 Then, create a pull request where the |
* Skip fragments missing new attribute after evolution * Copy fill values to result buffers * Fixing sparse readers for schema evolution. * Unit tests for evolved sparse read layouts (cherry picked from commit a7f385e) Co-authored-by: Luc Rancourt <lucrancourt@gmail.com> Co-authored-by: Shaun Reed <shaun.reed@tiledb.com>
* Skip fragments missing new attribute after evolution (#3528) * Skip fragments missing new attribute after evolution * Copy fill values to result buffers * Fixing sparse readers for schema evolution. * Unit tests for evolved sparse read layouts (cherry picked from commit a7f385e) Co-authored-by: Luc Rancourt <lucrancourt@gmail.com> Co-authored-by: Shaun Reed <shaun.reed@tiledb.com>
TYPE: BUG
DESC: Fix segfault after schema evolution when reading using
TILEDB_UNORDERED