Dense consolidation: set correct non-empty domain. #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing dense consolidation, we expanded the non empty domain of the read/write operations to full tiles so that the global order writer can write full tiles. This writer has not been built with the same computations that allow to write partial tiles like the ordered writer. This change still uses the tile aligned reads so that the dense reader provide full tiles, with fill values to the global order writer but it enables the consolidator to set a non tile aligned subarray on the writer, which is only used to set the non empty domain. That way, if users write fragments that are not tile aligned and consolidate, they will not get more data after consolidation with fill values. --- TYPE: IMPROVEMENT DESC: Dense consolidation: set correct non-empty domain.
|
This pull request has been linked to Shortcut Story #23049: Data corruption after consolidation of dense array. |
ihnorton
approved these changes
Nov 8, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
When performing dense consolidation, we expanded the non empty domain of the read/write operations to full tiles so that the global order writer can write full tiles. This writer has not been built with the same computations that allow to write partial tiles like the ordered writer. This change still uses the tile aligned reads so that the dense reader provide full tiles, with fill values to the global order writer but it enables the consolidator to set a non tile aligned subarray on the writer, which is only used to set the non empty domain. That way, if users write fragments that are not tile aligned and consolidate, they will not get more data after consolidation with fill values. --- TYPE: IMPROVEMENT DESC: Dense consolidation: set correct non-empty domain.
ihnorton
pushed a commit
that referenced
this pull request
Nov 12, 2022
…main. (#3641) * Update HISTORY.md for 2.12.2 * Dense consolidation: set correct non-empty domain. (#3635) When performing dense consolidation, we expanded the non empty domain of the read/write operations to full tiles so that the global order writer can write full tiles. This writer has not been built with the same computations that allow to write partial tiles like the ordered writer. This change still uses the tile aligned reads so that the dense reader provide full tiles, with fill values to the global order writer but it enables the consolidator to set a non tile aligned subarray on the writer, which is only used to set the non empty domain. That way, if users write fragments that are not tile aligned and consolidate, they will not get more data after consolidation with fill values. --- TYPE: IMPROVEMENT DESC: Dense consolidation: set correct non-empty domain. Co-authored-by: Seth Shelnutt <Shelnutt2@gmail.com> Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing dense consolidation, we expanded the non empty domain of the read/write operations to full tiles so that the global order writer can write full tiles. This writer has not been built with the same computations that allow to write partial tiles like the ordered writer. This change still uses the tile aligned reads so that the dense reader provide full tiles, with fill values to the global order writer but it enables the consolidator to set a non tile aligned subarray on the writer, which is only used to set the non empty domain. That way, if users write fragments that are not tile aligned and consolidate, they will not get more data after consolidation with fill values.
TYPE: IMPROVEMENT
DESC: Dense consolidation: set correct non-empty domain.