Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install rtools40 if needed #4061

Merged
merged 1 commit into from
Apr 27, 2023
Merged

install rtools40 if needed #4061

merged 1 commit into from
Apr 27, 2023

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Apr 24, 2023

rtools40 will soon not be preinstalled anymore on GHA, this installs it if needed.

TYPE: NO_HISTORY

@eddelbuettel
Copy link
Member

Thanks @jeroen -- to clarify this is needed only for the 32 bit builds for what is now old-old-rel aka R 4.1.* ? Which we could (and maybe should ?) also turn off, correct?

@jeroen
Copy link
Contributor Author

jeroen commented Apr 24, 2023

You need rtools40 for the dependencies and pacman build system:

https://github.com/TileDB-Inc/TileDB/blob/dev/.github/workflows/build-rtools40.yml#L30

If you don't care about R-4.1 support, you can indeed remove MINGW64 and MINGW32 from the build matrix, and only keep UCRT64, which is what is used for R-4.2 and up.

@jeroen
Copy link
Contributor Author

jeroen commented Apr 27, 2023

GitHub has now deployed their updated windows images, so I suspect your builds will start failing until you merge this.

@eddelbuettel
Copy link
Member

@ihnorton Should we merge this, unrelated CI fails notwithstanding? Change is only to the rtool40 yaml file.

@ihnorton ihnorton merged commit 8afb588 into TileDB-Inc:dev Apr 27, 2023
@ihnorton
Copy link
Member

Thanks @jeroen.

@teo-tsirpanis
Copy link
Member

This PR seems to be responsible for CI failures. https://github.com/TileDB-Inc/TileDB/actions/runs/4830151383/jobs/8606020094

@ihnorton
Copy link
Member

@jeroen chocolatey claims that rtool43 is already installed:

By installing, you accept licenses for the packages.
A newer version of rtools (v4.3.5550) is already installed.
 Use --allow-downgrade or --force to attempt to install older versions, or use --side-by-side to allow multiple versions.

However I don't see it on the runner-images software list (https://github.com/actions/runner-images).

jeroen added a commit to r-windows/install-rtools that referenced this pull request Apr 28, 2023
@jeroen
Copy link
Contributor Author

jeroen commented Apr 28, 2023

Thanks! I think it should be fixed now, can you retry the build?

@jeroen jeroen deleted the patch-1 branch April 28, 2023 12:58
@teo-tsirpanis
Copy link
Member

It works, thanks!

ihnorton pushed a commit that referenced this pull request May 22, 2023
TYPE: NO_HISTORY
(cherry picked from commit 8afb588)
ihnorton pushed a commit that referenced this pull request May 22, 2023
TYPE: NO_HISTORY
(cherry picked from commit 8afb588)
ihnorton pushed a commit that referenced this pull request May 22, 2023
TYPE: NO_HISTORY
(cherry picked from commit 8afb588)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants