-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install rtools40 if needed #4061
Conversation
Thanks @jeroen -- to clarify this is needed only for the 32 bit builds for what is now old-old-rel aka R 4.1.* ? Which we could (and maybe should ?) also turn off, correct? |
You need rtools40 for the dependencies and pacman build system: https://github.com/TileDB-Inc/TileDB/blob/dev/.github/workflows/build-rtools40.yml#L30 If you don't care about R-4.1 support, you can indeed remove MINGW64 and MINGW32 from the build matrix, and only keep UCRT64, which is what is used for R-4.2 and up. |
GitHub has now deployed their updated windows images, so I suspect your builds will start failing until you merge this. |
@ihnorton Should we merge this, unrelated CI fails notwithstanding? Change is only to the rtool40 yaml file. |
Thanks @jeroen. |
This PR seems to be responsible for CI failures. https://github.com/TileDB-Inc/TileDB/actions/runs/4830151383/jobs/8606020094 |
@jeroen chocolatey claims that rtool43 is already installed:
However I don't see it on the runner-images software list (https://github.com/actions/runner-images). |
Thanks! I think it should be fixed now, can you retry the build? |
It works, thanks! |
TYPE: NO_HISTORY (cherry picked from commit 8afb588)
TYPE: NO_HISTORY (cherry picked from commit 8afb588)
TYPE: NO_HISTORY (cherry picked from commit 8afb588)
rtools40 will soon not be preinstalled anymore on GHA, this installs it if needed.
TYPE: NO_HISTORY