Remove ValidityVector::init_bytemap.
#4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
force-pushed
the
validityvector-init_bytemap
branch
from
d796b16
to
b595e1b
Compare
teo-tsirpanis
force-pushed
the
validityvector-init_bytemap
branch
from
0074ae2
to
0f1f061
Compare
|
@KiterLuc CI is green. The PR is ready to merge. |
KiterLuc
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its place we directly use
ValidityVector's constructor that takes pointers to the buffer and the length.TYPE: IMPROVEMENT
DESC: Remove the internal
ValidityVector::init_bytemapmethod.