Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse unordered w/ dups reader: adding ignored tiles. #4200

Merged
merged 1 commit into from Jul 25, 2023

Conversation

KiterLuc
Copy link
Contributor

@KiterLuc KiterLuc commented Jul 24, 2023

This fixes reads where all tiles in a loop end up with 0 results because of query condition.


TYPE: BUG
DESC: Sparse unordered w/ dups reader: adding ignored tiles.

This fixes reads where all tiles in a loop end up with 0 results because of query condition.

---
TYPE: IMPROVEMENT
DESC: Sparse unordered w/ dups reader: adding ignored tiles.
Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to empirically assert that this branch helped with the CZI reported issue.

@ihnorton ihnorton merged commit 11e5d70 into dev Jul 25, 2023
56 checks passed
@ihnorton ihnorton deleted the lr/sparse-unordered-w-dups-reader-ignored-tiles branch July 25, 2023 12:01
@ihnorton
Copy link
Member

Labeling as bug-fix. Also confirmed added test coverage: the sparse unordered with dups test hangs without the fix.

KiterLuc added a commit that referenced this pull request Jul 25, 2023
This fixes reads where all tiles in a loop end up with 0 results because of query condition.

---
TYPE: BUG
DESC: Sparse unordered w/ dups reader: adding ignored tiles.

(cherry picked from commit 11e5d70)
Shelnutt2 pushed a commit that referenced this pull request Jul 26, 2023
This fixes reads where all tiles in a loop end up with 0 results because of query condition.

---
TYPE: BUG
DESC: Sparse unordered w/ dups reader: adding ignored tiles.

(cherry picked from commit 11e5d70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants