Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the AWS SDK to version 1.11.160. #4214

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

teo-tsirpanis
Copy link
Member

@teo-tsirpanis teo-tsirpanis commented Jul 26, 2023

SC-27055

This PR updates the AWS SDK to version 1.11.160, which is a requirement for the Conda-vcpkg build at TileDB-Inc/tiledb-feedstock#7. It's not tested yet, but it builds locally with vcpkg (updating the EP is TODO - or do we actually want to update it?).

In a previous version of the PR I had to bump vcpkg's builtin-baseline, updating many packages at once. What I did now is to copy-paste the relevant AWS SDK ports from microsoft/vcpkg@2c40186, minimizing the packages that were updated.


TYPE: IMPROVEMENT
DESC: Update the AWS SDK to version 1.11.160.

@shortcut-integration
Copy link

@teo-tsirpanis teo-tsirpanis changed the title [WIP] Update the AWS SDK to version 1.11.65. Update the AWS SDK to version 1.11.160. Sep 14, 2023
@teo-tsirpanis teo-tsirpanis marked this pull request as ready for review September 14, 2023 08:48
@teo-tsirpanis
Copy link
Member Author

CI is green. For anyone that might want to review it now, the actual changes start with 329956e.

One open question is, do we want to also update the ExternalProject? It might not be worth it given the use of vcpkg by default.

@eric-hughes-tiledb
Copy link
Contributor

One open question is, do we want to also update the ExternalProject? It might not be worth it given the use of vcpkg by default.

When vcpkg is mandatory, then it's time to remove the external project. We don't want a situation where it's possible to simultaneously (1) use an EP with an outdated SDK because (2) we're building S3 without vcpkg.

vcpkg doesn't need to be globally mandatory to avoid this failure, but it would have to be mandatory for S3.

Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not commit without one of these two:

  1. Make vcpkg mandatory for building with S3
  2. Update the S3 external project.

Given that the lifespan of all our EP's are short, option (1) seem more prudent. It's outside the scope of this comment to say whether this option is acceptable in light of other (potential) requirements.

@teo-tsirpanis
Copy link
Member Author

The EP has been updated. I launched a nightly build (they use EPs) and it succeeded. (https://github.com/teo-tsirpanis/TileDB/actions/runs/6222922998)

@teo-tsirpanis teo-tsirpanis dismissed eric-hughes-tiledb’s stale review September 18, 2023 15:13

The EP has been updated to the same AWS SDK version as we use with vcpkg.

@ihnorton ihnorton merged commit c524631 into TileDB-Inc:dev Sep 22, 2023
50 checks passed
@teo-tsirpanis teo-tsirpanis deleted the aws-sdk-update branch September 22, 2023 15:12
teo-tsirpanis added a commit to teo-tsirpanis/TileDB that referenced this pull request Oct 3, 2023
ihnorton added a commit to ihnorton/TileDB that referenced this pull request Dec 6, 2023
ihnorton added a commit to ihnorton/TileDB that referenced this pull request Dec 6, 2023
teo-tsirpanis added a commit that referenced this pull request Jan 10, 2024
teo-tsirpanis added a commit that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants