-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the AWS SDK to version 1.11.160. #4214
Conversation
This pull request has been linked to Shortcut Story #27055: Update to the latest version of the AWS SDK and take advantage of its native concurrency support.. |
ab9fa90
to
fffc3a3
Compare
CI is green. For anyone that might want to review it now, the actual changes start with 329956e. One open question is, do we want to also update the |
When vcpkg is mandatory, then it's time to remove the external project. We don't want a situation where it's possible to simultaneously (1) use an EP with an outdated SDK because (2) we're building S3 without vcpkg. vcpkg doesn't need to be globally mandatory to avoid this failure, but it would have to be mandatory for S3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not commit without one of these two:
- Make vcpkg mandatory for building with S3
- Update the S3 external project.
Given that the lifespan of all our EP's are short, option (1) seem more prudent. It's outside the scope of this comment to say whether this option is acceptable in light of other (potential) requirements.
84f960a
to
8917ca3
Compare
The EP has been updated. I launched a nightly build (they use EPs) and it succeeded. (https://github.com/teo-tsirpanis/TileDB/actions/runs/6222922998) |
The EP has been updated to the same AWS SDK version as we use with vcpkg.
Forgot to update in TileDB-Inc#4214.
This reverts commit c524631.
This reverts commit c524631.
This reverts commit c524631.
This reverts commit c524631.
SC-27055
This PR updates the AWS SDK to version 1.11.160, which is a requirement for the Conda-vcpkg build at TileDB-Inc/tiledb-feedstock#7. It's not tested yet, but it builds locally with vcpkg (updating the EP is TODO - or do we actually want to update it?).
In a previous version of the PR I had to bump vcpkg's
builtin-baseline
, updating many packages at once. What I did now is to copy-paste the relevant AWS SDK ports from microsoft/vcpkg@2c40186, minimizing the packages that were updated.TYPE: IMPROVEMENT
DESC: Update the AWS SDK to version 1.11.160.