Fix static linking failures and build ExampleExe_static on Windows.
#4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
commented
Sep 8, 2023
There was a problem hiding this comment.
The pcre2 port is a copy of the one in microsoft/vcpkg#31928.
|
CI is green. |
ihnorton
approved these changes
Sep 11, 2023
ihnorton
reviewed
Sep 11, 2023
teo-tsirpanis
added a commit
to teo-tsirpanis/TileDB
that referenced
this pull request
Sep 15, 2023
…TileDB-Inc#4336) * Update the pcre2 and libmagic ports. * Re-enable building `ExampleExe_static` on Windows. * FIx more linker errors. * Fix `ExampleExe_static` not being built. * Add missing Win32 libraries for Azure and S3. --- TYPE: BUILD DESC: Fix static linking failures and build ExampleExe_static on Windows.
ihnorton
pushed a commit
that referenced
this pull request
Sep 16, 2023
…#4336) (#4360) * Update the pcre2 and libmagic ports. * Re-enable building `ExampleExe_static` on Windows. * FIx more linker errors. * Fix `ExampleExe_static` not being built. * Add missing Win32 libraries for Azure and S3. --- TYPE: BUILD DESC: Fix static linking failures and build ExampleExe_static on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: BUILD
DESC: Fix static linking failures and build ExampleExe_static on Windows.