Improve missing enumeration value error message #4339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #33895: [CORE] Fix error message when an enumeration value is missing.. |
Shelnutt2
approved these changes
Sep 8, 2023
Previously, the error message was a cryptic message about a failed integral cast which is terrible for user experience. This updates things to make the error message specifically state that the enumeration value wasn't found.
davisp
force-pushed
the
pd/sc-33895/fix-enumeration-value-not-found-error-message
branch
from
37d4036
to
c35ce63
Compare
johnkerl
approved these changes
Sep 8, 2023
ihnorton
deleted the
pd/sc-33895/fix-enumeration-value-not-found-error-message
branch
github-actions bot
pushed a commit
that referenced
this pull request
Sep 9, 2023
Previously, the error message was a cryptic message about a failed integral cast which is terrible for user experience. This updates things to make the error message specifically state that the enumeration value wasn't found. --- TYPE: IMPROVEMENT DESC: Fix enumeration value not found error message (cherry picked from commit 79a5406)
ihnorton
pushed a commit
that referenced
this pull request
Sep 11, 2023
Previously, the error message was a cryptic message about a failed integral cast which is terrible for user experience. This updates things to make the error message specifically state that the enumeration value wasn't found. --- TYPE: IMPROVEMENT DESC: Fix enumeration value not found error message (cherry picked from commit 79a5406) Co-authored-by: Paul J. Davis <paul.davis@tiledb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the error message was a cryptic message about a failed integral cast which is terrible for user experience. This updates things to make the error message specifically state that the enumeration value wasn't found.
TYPE: IMPROVEMENT
DESC: Fix enumeration value not found error message