Compilation fix for GCC 9.4 of Ubuntu 20.04 #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC <5 is no longer supported
ihnorton
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Compilation fix for GCC 9.4 of Ubuntu 20.04 * Update type.h: GCC <5 is no longer supported
eric-hughes-tiledb
added a commit
that referenced
this pull request
Sep 20, 2023
The macro changed in #4355 is eliminated here. It was only used in two places, and the new macro added nothing over its replacement text.
ihnorton
pushed a commit
that referenced
this pull request
Sep 20, 2023
The macro changed in #4355 is eliminated here. It was only used in two places, and the new version of the macro added nothing over its replacement text. --- TYPE: NO_HISTORY DESC: Followup to 4355: eliminate the macro
ihnorton
pushed a commit
that referenced
this pull request
Sep 20, 2023
* Compilation fix for GCC 9.4 of Ubuntu 20.04 * Update type.h: GCC <5 is no longer supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc 9.4 doesn't like "not defined"
And there was a typo GNUG --> GNUC
This should be backported to the 2.17 branch
TYPE: CPP_API
DESC: Compilation fix for GCC 9.4 of Ubuntu 20.04