Fix UBSAN error in the Enumeration CPP API #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #34255: Fix UBSAN warning in builds of TileDB-R. |
davisp
force-pushed
the
pd/sc-34255/fix-ubsan-error
branch
from
bc95185
to
e25c393
Compare
Apparently one of our many build chains decided that faking a default parameter for a `tiledb_datatype_t` is undefined behavior, which, fair enough. The fix should be to just use a std::optional instead.
davisp
force-pushed
the
pd/sc-34255/fix-ubsan-error
branch
from
e25c393
to
43200cf
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
Apparently one of our many build chains decided that faking a default parameter for a `tiledb_datatype_t` is undefined behavior, which, fair enough. The fix should be to just use a std::optional instead. --- TYPE: BUG DESC: Fix UBSAN error in the Enumeration CPP API (cherry picked from commit 02e6408)
ihnorton
pushed a commit
that referenced
this pull request
Sep 20, 2023
Apparently one of our many build chains decided that faking a default parameter for a `tiledb_datatype_t` is undefined behavior, which, fair enough. The fix should be to just use a std::optional instead. --- TYPE: BUG DESC: Fix UBSAN error in the Enumeration CPP API (cherry picked from commit 02e6408)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently one of our many build chains decided that faking a default parameter for a
tiledb_datatype_tis undefined behavior, which, fair enough. The fix should be to just use a std::optional instead.TYPE: CPP_API
DESC: Fix UBSAN error in the Enumeration CPP API
TYPE: CPP_API
DESC: 2.17.1 Release notes: breaking change from 2.17.0 in experimental C++ API, in order to fix UB.