Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HDFS to as_built. #4364

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Add HDFS to as_built. #4364

merged 2 commits into from
Sep 20, 2023

Conversation

teo-tsirpanis
Copy link
Member

SC-34351

TYPE: BUG
DESC: Specify whether the HDFS backend is enabled in the string returned by tiledb_as_built_dump.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #34351: HDFS is missing from as_built..

bekadavis9
bekadavis9 requested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@bekadavis9 bekadavis9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases in tiledb/as_built/test/unit_as_built.cc and test/src/unit-capi-as_built.cc for consistency

@teo-tsirpanis
Copy link
Member Author

Done.

@ihnorton ihnorton merged commit fc72a4e into TileDB-Inc:dev Sep 20, 2023
50 checks passed
@teo-tsirpanis teo-tsirpanis deleted the as_built_hdfs branch September 20, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bekadavis9 bekadavis9 bekadavis9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teo-tsirpanis @bekadavis9 @ihnorton