Add memory tracking to Enumeration loading #4395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #32987: [CORE] Add enumeration data to memory budgeting. |
davisp
force-pushed
the
pd/sc-32987/add-enumeration-memory-tracking
branch
2 times, most recently
from
e3b28ee
to
048f310
Compare
KiterLuc
reviewed
Oct 3, 2023
tiledb/sm/array/array_directory.cc
Outdated
| auto timer_se = resources_.get().stats().start_timer("sm_load_enumeration"); | ||
|
|
||
| auto enmr_uri = uri_.join_path(constants::array_schema_dir_name) | ||
| .join_path(constants::array_enumerations_dir_name) | ||
| .join_path(enumeration_path); | ||
|
|
||
| uint64_t size = 0; |
There was a problem hiding this comment.
Can we use the tile size below to prevent the file size operation?
There was a problem hiding this comment.
We sure can!
Though for others, we chatted real quick OOB and went through a couple permutations of passing the MemoryTracker to GenericTileIO::load then passing the file size read instead of the tracker to avoid the duplicate file sizes. And then we figured out that the file size isn't correct anyway since its the compressed size. So now we're back to using tile.size() instead and future work will be required to preemptively check whether we can load before reading.
davisp
force-pushed
the
pd/sc-32987/add-enumeration-memory-tracking
branch
from
048f310
to
e224117
Compare
KiterLuc
approved these changes
Oct 3, 2023
This adds a new MemoryTracker type for tracking Enumeration data usage.
davisp
force-pushed
the
pd/sc-32987/add-enumeration-memory-tracking
branch
from
e224117
to
0567f03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new MemoryTracker type for tracking Enumeration data usage.
TYPE: IMPROVEMENT
DESC: Add memory tracking to Enumeration loading