Fix infinite while loop for unsigned int label query #4404
Conversation
|
Thanks for the fix @jp-dark. Can we add a test for this case? |
Loop will now necessarily terminate eventually.
I added a test for this case and further modified the loop so if there is a different missing edge case, it will at least error out eventually. |
| @@ -638,7 +638,11 @@ IndexType OrderedDimLabelReader::search_for_range( | |||
|
|
|||
| // Run a binary search. | |||
| Op cmp; | |||
There was a problem hiding this comment.
I wrapped the original loop with if (left_index != right_index) { and it seems to be fixing the added test case... Does it also fix your original case?
There was a problem hiding this comment.
It should. The original case was the result of a typo in a Python examples: If the right side of the tile is 0 on an unsigned dimension, then subtracting 1 from the right side creates a very large number and the end condition is never met. This is only possible if the tile size is 1 (the typo).
The ordered label reader had an infinite loop for dimension labels on unsigned integers when the lower bound of the desired result was zero.
TYPE: BUG
DESC: Fix bug in ordered label reader for unsigned integers