Query aggregates REST support #4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extend c API aggregate tests to use serialization wrappers
to report their input field name(shouldnt exist)
serialization wrappers
|
This pull request has been linked to Shortcut Story #29965: [core-rest] Support for aggregate pushdown. |
Shelnutt2
reviewed
Oct 12, 2023
| auto aggregate_builder = aggregates_builder[i]; | ||
| aggregate_builder.setOutputFieldName(agg.first); | ||
| aggregate_builder.setName(agg.second->aggregate_name()); | ||
| // TODO: Currently COUNT reports that its |
There was a problem hiding this comment.
Why do we not support a name for the count channel?
KiterLuc
requested changes
Oct 17, 2023
|
|
||
| namespace tiledb::sm { | ||
|
|
||
| class Operation { |
KiterLuc
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rest support for query aggregates.
TYPE: FEATURE
DESC: Query aggregates REST support