Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vcpkg triplets for RelWithDebInfo. #4669

Merged
merged 7 commits into from Feb 8, 2024
Merged

Conversation

teo-tsirpanis
Copy link
Member

SC-39876


TYPE: BUILD
DESC: Add vcpkg triplets for RelWithDebInfo.

Unlike ASAN we don't have to fail if a base triplet is not specified because building some libraries with symbols and some without is OK.
Move a section from CONTRIBUTING.md and fix a paragraph.
Copy link

@teo-tsirpanis
Copy link
Member Author

@teo-tsirpanis teo-tsirpanis marked this pull request as ready for review January 25, 2024 23:58
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KiterLuc KiterLuc merged commit 645f285 into dev Feb 8, 2024
65 checks passed
@KiterLuc KiterLuc deleted the teo/relwithdebinfo-triplets branch February 8, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants