-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate std::pmr memory tracking for class ArraySchema. #4696
Merged
KiterLuc
merged 16 commits into
dev
from
pd/abigalekim/sc-40462/pmr-memory-tracking-arrayschema
Feb 23, 2024
Merged
Integrate std::pmr memory tracking for class ArraySchema. #4696
KiterLuc
merged 16 commits into
dev
from
pd/abigalekim/sc-40462/pmr-memory-tracking-arrayschema
Feb 23, 2024
Commits on Feb 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8abe584 - Browse repository at this point
Copy the full SHA 8abe584View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50036be - Browse repository at this point
Copy the full SHA 50036beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b57ae3 - Browse repository at this point
Copy the full SHA 0b57ae3View commit details -
Some code review changes have been addressed:
- Deleted default constructor of class tiledb::sm::ArraySchema - Changed copy_with_new_memory_tracker to clone - Deleted constructor with pmr vector. Problems remaining: - had to make copy constructor public since a protected one does not work with our version of make_shared.
Configuration menu - View commit details
-
Copy full SHA for 07b9f08 - Browse repository at this point
Copy the full SHA 07b9f08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1701cce - Browse repository at this point
Copy the full SHA 1701cceView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3b63f6 - Browse repository at this point
Copy the full SHA c3b63f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f1053a - Browse repository at this point
Copy the full SHA 6f1053aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee51025 - Browse repository at this point
Copy the full SHA ee51025View commit details -
Configuration menu - View commit details
-
Copy full SHA for e80e797 - Browse repository at this point
Copy the full SHA e80e797View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a79567 - Browse repository at this point
Copy the full SHA 2a79567View commit details -
Configuration menu - View commit details
-
Copy full SHA for e74f0b8 - Browse repository at this point
Copy the full SHA e74f0b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83eece0 - Browse repository at this point
Copy the full SHA 83eece0View commit details
Commits on Feb 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c636664 - Browse repository at this point
Copy the full SHA c636664View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b37991 - Browse repository at this point
Copy the full SHA 4b37991View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a62d55 - Browse repository at this point
Copy the full SHA 3a62d55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 273c51f - Browse repository at this point
Copy the full SHA 273c51fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.