Fix throwing exception on remote incomplete queries with aggregates. #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #42786: Remote incomplete queries with aggregates fail with a vague message.. |
KiterLuc
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-42786
Validated with a locally built REST server.
Before:
[TileDB::REST] Error: Error submitting query to REST; server returned no data. Curl error: Error in libcurl POST operation: libcurl error message 'CURLE_OK'; HTTP code 400; server response data '{"code":2208,"message":"Error serializing query: C API: unknown exception type; no further information","request_id":"a0f026a8-8507-4c54-b592-5166c7d4f0b6"}'.After:
[TileDB::REST] Error: Error submitting query to REST; server returned no data. Curl error: Error in libcurl POST operation: libcurl error message 'CURLE_OK'; HTTP code 400; server response data '{"code":2208,"message":"Error serializing query: [TileDB::Serialization] Error: Cannot serialize; exception: [TileDB::Serialization] Error: Aggregates are not currently supported in incomplete remote queries","request_id":"c6638565-d80d-4c0c-88a6-52c1a748df1a"}'.TYPE: BUG
DESC: Provide a clear exception message when performing remote incomplete queries with aggregates