Improve diagnostics when an Azure endpoint is not configured. #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #43870: Remove azure warning when not using azure credentials. |
robertbindar
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Azure had to be compiled in to see this warning. This looks very much alright, thanks @teo-tsirpanis
dudoslav
pushed a commit
that referenced
this pull request
Apr 17, 2024
[SC-43870](https://app.shortcut.com/tiledb-inc/story/43870/remove-azure-warning-when-not-using-azure-credentials) This PR changes the Azure VFS to fail with an explicit error if an operation on the Azure VFS was attempted, but an endpoint to Azure Blob Storage could not be determined based on the `vfs.azure.storage_account_name` and `vfs.azure.blob_endpoint` configuration options. The previous behavior was to emit a warning, which happened at the initialization of the VFS class if Azure is enabled, regardless of whether Azure is being actually used. That warning is no longer emitted. --- TYPE: IMPROVEMENT DESC: Improve diagnostics when an Azure endpoint is not configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-43870
This PR changes the Azure VFS to fail with an explicit error if an operation on the Azure VFS was attempted, but an endpoint to Azure Blob Storage could not be determined based on the
vfs.azure.storage_account_nameandvfs.azure.blob_endpointconfiguration options. The previous behavior was to emit a warning, which happened at the initialization of the VFS class if Azure is enabled, regardless of whether Azure is being actually used. That warning is no longer emitted.TYPE: IMPROVEMENT
DESC: Improve diagnostics when an Azure endpoint is not configured.