Bump the vcpkg builtin-baseline.
#5010
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
commented
May 27, 2024
| |----------------------------|---------------------------------------------------------------------------------------------------------| | ||
| | `libmagic` | Updating to the upstream port deferred due to failures. | | ||
| | `openssl` | Pinning to OpenSSL 1.1 until we can move to 3.0 in January 2024. | | ||
| | `pcre2` | To be removed alongside libmagic. | |
There was a problem hiding this comment.
The custom port for PCRE2 was applying some patches to its CMake build system, to make it usable from libmagic. These patches are now upstreamed.
| | `pcre2` | To be removed alongside libmagic. | | ||
| | `azure-storage-common-cpp` | Patching to disable default features on libxml2 (https://github.com/Azure/azure-sdk-for-cpp/pull/5221). | | ||
| | `libfaketime` | Port does not yet exist upstream | | ||
| | `vcpkg-cmake-config` | Patching to fix build issues with CMake 3.29.1. (https://github.com/microsoft/vcpkg/pull/38017) | |
There was a problem hiding this comment.
Subsequent versions of CMake 3.29.x have fixed the breaking change and this custom port is no longer needed.
This is not necessary and in fact it never had the intended effect; disabling default features had to be and was made in `azure-storage-common-cpp`.
teo-tsirpanis
force-pushed
the
teo/bump-vcpkg-baseline
branch
from
4bc0adb
to
d8ae79d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-48154
This PR bumps the vcpkg
builtin-baselinewhich causes all of our dependencies to be updated to the most recent versions available on vcpkg. Some of our custom ports are no longer needed and were removed as well.To view the full list of updated ports, you can clone vcpkg and run
git diff 72010900b7cee36cea77aebb97695095c9358eaf 01f602195983451bc83e72f4214af2cbc495aa94 -- .\versions\baseline.json > baseline.diff. This is an abridged summary of the updated ports that we depend on:The bump to the baseline might cause configure errors due to the vcpkg repository being out of date In this case, try one of the following things:
VCPKG_ROOTenvironment variable, update the vcpkg repository to the latest available commit, and try configuring again.build/_depsand configure again. If it doesn't work, try performing a clean build.Let me know if any additional testing is required.
TYPE: BUILD
DESC: Update vcpkg version baseline to microsoft/vcpkg@01f6021.