Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Issue if GitHub Actions workflows fail #2

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

jdblischak
Copy link
Collaborator

@jdblischak jdblischak commented Jan 23, 2023

If one of the GitHub Actions workflows failed, open an Issue (or comment on existing open Issue)

To do prior to merge:

  • Manually create Issue label "nightly-failure"
  • Set default GitHub Actions token to be read-only. This is a personal preference for increased security. By default (at least in my personal repos), the default token has read and write access. I prefer to escalate permissions individually (eg issues: write as I use here)

Limitations:

  • This uses the same Issue label for each recipe. Given that these workflows are largely tinkering with recipes, they are likely to fail for the same reasons. And even if not, the extra complexity of multiple labels doesn't seem worth it. I can add the complexity if requested

cc: @shaunrd0 ,@ihnorton
xref: #1

@shaunrd0
Copy link
Collaborator

Thanks John, I've flipped default permissions to read only for the GHA token in this repository 👍

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ihnorton ihnorton merged commit b6ef7eb into TileDB-Inc:main Jan 23, 2023
@jdblischak jdblischak deleted the open-issue branch January 27, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants