Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Core to 2.18 #105

Merged
merged 15 commits into from
Jan 5, 2024
Merged

Bump Core to 2.18 #105

merged 15 commits into from
Jan 5, 2024

Conversation

awenocur
Copy link
Contributor

No description provided.

Copy link

This pull request has been linked to Shortcut Story #37199: Release VCF 0.27 with Embedded 2.18.

@johnkerl
Copy link
Contributor

johnkerl commented Dec 14, 2023

OSX CI failed with
https://dev.azure.com/TileDB-Inc/CI/_build/results?buildId=37133&view=logs&jobId=58ac6aab-c4bc-5de2-2894-98e408cc8ec9&j=58ac6aab-c4bc-5de2-2894-98e408cc8ec9&t=933f325c-924e-533d-4d95-e93b5843ce8b

Fatal error condition occurred in /Users/runner/miniforge3/conda-bld/aws-c-common_1701169789367/work/source/allocator.c:172: allocator != ((void*)0)

which is a KP from TileDB-SOMA involving pyarrow>=13.0, MacOS only

What's weird here is TileDB-VCF is getting (as shown in the logs) pyarrow==9 ...

@johnkerl
Copy link
Contributor

Also weird is that the KP @ihnorton and I have discussed affects MacOS x86_64 and arm64 equally, whereas here we see the fail only on x86_64 ... 🤔

@ihnorton
Copy link
Member

Also weird is that the KP @ihnorton and I have discussed affects MacOS x86_64 and arm64 equally, whereas here we see the fail only on x86_64 ... 🤔

We don't run tests on arm (no native hardware for azure pipelines)

@jdblischak
Copy link
Collaborator

I don't know why this error is surfacing now. Looking through the various feedstocks, I see there have been multiple updates in the last week to aws-sdk-cpp-feedstock and aws-crt-cpp-feedstock

https://github.com/conda-forge/aws-sdk-cpp-feedstock/pulls?q=is%3Apr+is%3Aclosed
https://github.com/conda-forge/aws-crt-cpp-feedstock/pulls?q=is%3Apr+is%3Aclosed

But the 9.0.x branch of arrow-cpp-feedstock hasn't been updated in 3 months

https://github.com/conda-forge/arrow-cpp-feedstock/commits/9.0.x/

So maybe some new fix in an AWS library hasn't been backported yet?

@johnkerl
Copy link
Contributor

@jdblischak I tried installing tiledb-vcf 0.27.0 on my mac x86 laptop, along with core 2.18.3 et al. (which it already had), and pyarrow 9, and I cannot repro the above CI fail ...

@awenocur
Copy link
Contributor Author

retrying with TileDB-VCF 0.27.1; hopefully it'll pull in Core 2.18.3 instead of Core 2.18.2 this time, which in turn will pull in the updated AWS SDK

@awenocur awenocur force-pushed the sc-37199 branch 3 times, most recently from eb74c7f to 6e2714c Compare December 20, 2023 01:56
@ihnorton
Copy link
Member

ihnorton commented Jan 4, 2024

Reverted to 2ee1044 which passed on linux and macos-arm64. Assuming that passes again on this run, we'll ship it as-is and pick up the osx-64 issue separately.

@ihnorton ihnorton merged commit 0234b10 into TileDB-Inc:master Jan 5, 2024
2 of 5 checks passed
@ihnorton
Copy link
Member

ihnorton commented Jan 5, 2024

sc-38823 for the failure here.

Copy link

This pull request has been linked to Shortcut Story #38823: AWS SDK assert due to Aws::InitAPI usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants