Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EP32xx state detection #63

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fix EP32xx state detection #63

merged 1 commit into from
Apr 17, 2024

Conversation

TillFleisch
Copy link
Owner

@TillFleisch TillFleisch commented Apr 16, 2024

This PR fixes an issue on EP32xx machines which was introduced by #45.

Try this PR using:

external_components:
  - source: github://TillFleisch/ESPHome-Philips-Smart-Coffee@fix_EP3243_state_detection
    refresh: 30min

Close #60

@TillFleisch
Copy link
Owner Author

@quack3d can you check if this fixes #60 for you?

@quack3d
Copy link

quack3d commented Apr 17, 2024

Seems to work like v3.0.0. 👍

@TillFleisch TillFleisch merged commit e710147 into main Apr 17, 2024
7 checks passed
@quack3d
Copy link

quack3d commented Apr 18, 2024

Looks like I spoke too soon. Turning it on it goes to 'Cleaning' and then 'Brewing Latte Macchiato' and then back to 'Cleaning'. Same thing when I turn it off.

@TillFleisch
Copy link
Owner Author

I do occasionally also see an invalid state (Espresso) when starting the machine(only once). This was also the case prior to any of the related changes. I should probably rework the state detection some day but it hasn't bothered me enough yet (I'm also somewhat time constraint from time to time).

Is the major machine breaking problem fixed? Do the Latte/Americano options work as intended (in contrast to the wrong behaviour described in #60)?

@quack3d
Copy link

quack3d commented Apr 19, 2024

Yeah, everything else works as it should (Latte/Americano etc). But since it's reporting a Latte every time I start and shut down the machine I get weird results in statistics. For each coffee there are 2 Lattes. 😁

In the code you changed, does it make sense that v3.0.0 does not have this issue but @main now does?

@quack3d
Copy link

quack3d commented Apr 28, 2024

Today I have that same preparing - latte - preparing - latte - preparing - latte - cleaning - latte - cleaning - latte - cleaning - latte cycle... It has been just a few latte reports this week. 1-7 depending on how many coffees but today it said 74 lattes. I did upgrade ESPHome today. Not sure how that could affect anything.

@quack3d
Copy link

quack3d commented May 16, 2024

I went back to

  • source: github://TillFleisch/ESPHome-Philips-Smart-Coffee@v3.0.0
    refresh: 30min
    But strangely I still get a bunch of Brewing Latte Macchiato when powering on the machine. So it seems like the changes after v3.0.0 is not the culprit. Now I'm not sure what version to choose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suddenly lots of issues with previously working EP3243
2 participants