Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully mock up the context object to work with succeed and fail #11

Merged
merged 1 commit into from
May 23, 2015

Conversation

jonyo
Copy link
Contributor

@jonyo jonyo commented May 20, 2015

This would resolve #8

@Tim-B
Copy link
Owner

Tim-B commented May 20, 2015

Hi jayno, thanks for the pull request!

It looks like the Travis tests are failing, but there's another issue someone reported which gives a similar message to what the Travis results say. Could you confirm that the tests pass on your machine?

@jonyo
Copy link
Contributor Author

jonyo commented May 21, 2015

@Tim-B the tests fail on my box, even running develop. I think I know the problem, has to do with NPM global installation not being in the path even though it's installed globally. I've seen other packages that require parts of npm specify it in the package.json, will try that and see if tests pass (if so I'll do a separate PR for that).

@jonyo
Copy link
Contributor Author

jonyo commented May 21, 2015

@Tim-B It did fix it for my local tests, see PR #13. If you are fine with that and merge it, I'll rebase my 2 PR's to make sure they pass with the fixed NPM dependency.

@Tim-B
Copy link
Owner

Tim-B commented May 21, 2015

Thanks, I'll try and make time to work through your PRs this weekend.

Tim-B added a commit that referenced this pull request May 23, 2015
Fully mock up the context object to work with succeed and fail
@Tim-B Tim-B merged commit c83bdb7 into Tim-B:master May 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

context.succeed() and context.fail() when using lambda_invoke
2 participants