Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing AWS region from ARN, when ARN provided #25

Merged
merged 1 commit into from
Jul 23, 2015
Merged

Parsing AWS region from ARN, when ARN provided #25

merged 1 commit into from
Jul 23, 2015

Conversation

jvwing
Copy link
Contributor

@jvwing jvwing commented Jul 21, 2015

I wanted to get AWS region parsed out of the ARN, when ARN is provided for deployment.

  • Simple ARN parsing
  • Unit tests for ARN parsing
  • Integrated parsing into lambda_deploy, conditional on ARN being provided in options and region discovered by parsing.

Tim-B added a commit that referenced this pull request Jul 23, 2015
@Tim-B
Merge pull request #25 from jvwing/deploy_parse_arn_region
afb3ca3 
Parsing AWS region from ARN, when ARN provided
@Tim-B Tim-B merged commit afb3ca3 into Tim-B:master Jul 23, 2015
@Tim-B
Copy link
Owner

Tim-B commented Jul 24, 2015

Thanks for this great pull-request, I just published a new version to NPM with your changes.

@jvwing
Copy link
Contributor Author

jvwing commented Jul 24, 2015

My pleasure, thanks for merging and publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jvwing @Tim-B