Allow for all credential forms #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Improve README.md to list all possible authentication avenues
|
Thanks for the pull request! I'm still a bit undecided about whether this is a good idea. If we do want to support hard coded credentials, perhaps it would be better to provide an option for setting a path which is passed to That way you could set your hard coded credentials in a separate file to your Gruntfile (and therefore could be excluded from version control), but it might still avoid the complications of using a profile. |
|
@Tim-B The credentials JSON option is built in now, in addition to the hardcoding of access key and secret key |
|
@Tim-B Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I totally agree that credentials shouldn't be hardcoded.
Having said that, I think it should be allowed. I just implemented
grunt-awsand noticed that they support passed in keys but not profiles (although profiles can be used by using theAWS_PROFILEenvironment variable according to the AWS docs). I have a profile setup on my local computer, but other developers on my project may not have the same. I would rather have an IAM user which has specific permissions to support both projects and keep the credentials in an AWS supported credentials JSON file in the repo (yes, in the repo) instead of having to explain differences between hardcoded & profile (in addition to all the other credential methods)This pull request allows passing in credentials to the library via the Grunt config or a JSON file. It also improves the README.md to list all possible authentication avenues (IAM role, profile, hardcoded, JSON file, environment variables).