Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added package_folder option to lambda_invoke task #62

Merged
merged 3 commits into from
Jan 24, 2016

Conversation

dcaravana
Copy link
Contributor

This simple addition makes invoke consistent with package.

In fact you can now invoke a lambda function from another folder: using package_folder option, the current execution folder will be changed to it so the related modules can be found.

This is useful for example when dealing with many functions and avoid continuously changing folder in the shell.

@dcaravana
Copy link
Contributor Author

Not sure why it's failing, CI log is empy.

Any clue?

@Tim-B
Copy link
Owner

Tim-B commented Jan 23, 2016

Hi Diego, thanks for the pull request!

Do the tests only fail on Travis, or both locally and on Travis?

Also, it would be great if there was a unit test for this new option. Something along the lines of a function in a subdirectory and ensuring the CWD switches into that directory then back to the initial directory correctly.

@dcaravana
Copy link
Contributor Author

Hi Tim, happy to contribute!

I've just ran the tests and everything works as expected locally (except for a npm WARN installMany), so I think it's only on Travis.

Great idea to add a new test, I'll do it ASAP.

@dcaravana
Copy link
Contributor Author

Tests pass now on Travis, funny that the problem was an unneeded require('process')!

@dcaravana
Copy link
Contributor Author

Test done (fun!).

Please double check it as it now contains part of the output generated by invoke - not sure how to avoid this duplication.

Tim-B added a commit that referenced this pull request Jan 24, 2016
added package_folder option to lambda_invoke task
@Tim-B Tim-B merged commit 88d9eed into Tim-B:master Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants