Changes

Tim-Brooks · Jun 9, 2023 · bd86c9e · bd86c9e
1 parent 82c3a04
commit bd86c9e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/server/src/internalClusterTest/java/org/elasticsearch/index/shard/SearchIdleIT.java b/server/src/internalClusterTest/java/org/elasticsearch/index/shard/SearchIdleIT.java
@@ -200,11 +200,7 @@ public void testPendingRefreshWithIntervalChange() throws Exception {
     private static void scheduleRefresh(IndexShard shard, boolean expectRefresh) {
         PlainActionFuture<Boolean> future = PlainActionFuture.newFuture();
         shard.scheduledRefresh(future);
-        if (expectRefresh) {
-            assertTrue(future.actionGet());
-        } else {
-            assertFalse(future.actionGet());
-        }
+        assertThat(future.actionGet(), equalTo(expectRefresh));
     }
 
     private void ensureNoPendingScheduledRefresh(ThreadPool threadPool) {

diff --git a/server/src/main/java/org/elasticsearch/index/engine/ReadOnlyEngine.java b/server/src/main/java/org/elasticsearch/index/engine/ReadOnlyEngine.java
@@ -435,7 +435,7 @@ public RefreshResult refresh(String source) {
 
     @Override
     public void maybeRefresh(String source, ActionListener<RefreshResult> listener) throws EngineException {
-        ActionListener.completeWith(listener, () -> RefreshResult.NO_REFRESH);
+        listener.onResponse(RefreshResult.NO_REFRESH);
     }
 
     @Override