Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of ZigZagFilter() to Pandas Dataframe instead of dict #22

Closed
Tim55667757 opened this issue Jan 16, 2023 · 1 comment
Closed

Change type of ZigZagFilter() to Pandas Dataframe instead of dict #22

Tim55667757 opened this issue Jan 16, 2023 · 1 comment
Assignees
@Tim55667757
Labels
Task A small task or improvements
Milestone
release-1.4

Comments

@Tim55667757
Copy link
Owner

Now: return {"datetimes": datetimes[filteredPoints], "filtered": values[filteredPoints]}
Need: `return pd.DataFrame()" where "datetimes" and "filtered" is a pd.Series

Check all dependent functions.
@Tim55667757 Tim55667757 added this to the release-1.4 milestone Jan 16, 2023
@Tim55667757 Tim55667757 self-assigned this Jan 16, 2023
@Tim55667757 Tim55667757 added the Task A small task or improvements label Jan 16, 2023
Tim55667757 added a commit that referenced this issue Nov 25, 2023
@Tim55667757
#22 Type of ZigZagFilter() was changed to Pandas Dataframe instead of…
0d8c299 
… dict
Tim55667757 added a commit that referenced this issue Nov 25, 2023
@Tim55667757
#22 unit-test was fixed
584e9a9
@Tim55667757
Copy link
Owner Author

Implemented in v1.4.*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tim55667757 Tim55667757

Labels
Task A small task or improvements
Projects
None yet
Milestone
release-1.4
Development

No branches or pull requests
1 participant
@Tim55667757