Rewrite #15
Merged
Rewrite #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2016
Closed
|
@Jeff-Lewis You also had an interest in this I think. Want to take a look? |
overlookmotel
force-pushed
the
rewrite
branch
from
1ce62aa
to
ad6e5d0
Compare
overlookmotel
force-pushed
the
rewrite
branch
from
ad6e5d0
to
0edc7fd
Compare
|
Changes Unknown when pulling 0edc7fd on overlookmotel:rewrite into * on TimBeyer:master*. |
|
@Jeff-Lewis I see you've been forking and having a play. Thanks for taking a look at it. |
|
@TimBeyer Haven't heard from you in a while so have gone ahead and released this as v2.0.0. Hope that's OK with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #9 and #13, this PR is a complete re-write of both cls-bluebird and a new test suite. It's taken me a while!
The new patch works with both latest Bluebird v2.x and v3.x.
The tests are pretty comprehensive! There's just over 100,000 tests in total. Perhaps insane, but I've aimed to cover every possible combination of inputs to ensure there's no edge cases that aren't covered.
@TimBeyer Can you please have a look and see if you're happy with this? I'm keen to get this integrated into Sequelize swiftly and so would like to release and publish as soon as possible.