Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scipy dep #544

Closed
danbider opened this issue Jun 27, 2023 · 7 comments
Closed

scipy dep #544

danbider opened this issue Jun 27, 2023 · 7 comments
Labels
bug Something isn't working high priority (first issues that will be worked on)

Comments

@danbider
Copy link

Hi!

scipy is used in a few places in the repo, but doesn't appear in the deps. should be added? or eliminated from repo?

@TimDettmers
Copy link
Owner

Thank you for reporting this. scipy is needed for the 4-bit NormalFloat data type calculation. So it is best to add it to the requirements.

@TimDettmers
Copy link
Owner

It has been added. Thanks again for reporting.

@davidthomas426
Copy link

I don't think this addresses the problem.

Note the Requires: line in pip show:

$ pip show bitsandbytes
Name: bitsandbytes
Version: 0.40.2
Summary: k-bit optimizers and matrix multiplication routines.
Home-page: https://github.com/TimDettmers/bitsandbytes
Author: Tim Dettmers
Author-email: dettmers@cs.washington.edu
License: MIT
Location: /home/ubuntu/.local/lib/python3.10/site-packages
Requires:
Required-by:

@dulalbert
Copy link
Contributor

It has been added. Thanks again for reporting.

I think you need to add it to install_requires too.
#525 (comment)

@failable
Copy link

How to fix?

@ashleykleynhans
Copy link

This issue is closed but its still an issue in the latest version 0.41.1.

@goetzc
Copy link

goetzc commented Nov 28, 2023

I can confirm it's still an open issue when installing from pip.

@TimDettmers 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority (first issues that will be worked on)
Projects
None yet
Development

No branches or pull requests

7 participants