Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent from steadily zooming in when cycling between alternate aspectRatios and original #534

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

yhkaplan
Copy link
Contributor

@yhkaplan yhkaplan commented Aug 19, 2022

Hi Tim, it's Josh from the Tokyo iOS Meetup. This doesn't keep the zoom level, but I think it makes sense to reset it when going back to the default one at least. Tell me what you think/if you disagree!

Issue below related

Before / After

Simulator.Screen.Recording.-.iPhone.13.-.2022-08-19.at.15.21.10.mp4
Simulator.Screen.Recording.-.iPhone.13.-.2022-08-19.at.15.22.00.mp4

@yhkaplan yhkaplan marked this pull request as ready for review August 19, 2022 22:29
@TimOliver
Copy link
Owner

Hey @yhkaplan! Was great to see you on Threads the other day! Sorry for the delay! It's been a while since I got a hot minute to maintain this library. 🫠

Fantastic! What a simple, but elegant improvement to the UX. Thanks so much for that!

@TimOliver TimOliver merged commit e47dd62 into TimOliver:main Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants