Correct mksquashfs
error and bump version
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Summary
These are the highlights of the changes. More details can be found below.
There are three main changes being made:
SOURCE_DATE_EPOCH
environment variable is being unset to resolve themksquashfs
error.bazecor.desktop
is being referenced asBazecor.desktop
when extracting the AppImage.python
is being added a dependency.Details
mksquashfs
will throw a error if both theSOURCE_DATE_EPOCH
environment variable and the-all-time
flag are set. This was happening sincemakepkg
will set theSOURCE_DATE_EPOCH
environment variable and@reforged/maker-appimage
will always set the-all-time
flag. This issue can be avoided by removing theSOURCE_DATE_EPOCH
environment variable.In the AppImage it seems like
bazecor.desktop
is nowBazecor.desktop
. I was getting a file not found error without this change.python
sincenode-gyp
is in the dependency chain for Bazecor and it requires python. Withoutpython
node-gyp
will throw an error saying it cannot find python.Testing Evidence
As mentioned before, I tested the PKGBUILD in a clean chroot. I was able to install the package created using the command