Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct mksquashfs error and bump version #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sagar794
Copy link

@sagar794 sagar794 commented Jan 21, 2024

Bug Fix

Summary

These are the highlights of the changes. More details can be found below.

There are three main changes being made:

  1. SOURCE_DATE_EPOCH environment variable is being unset to resolve the mksquashfs error.
  2. bazecor.desktop is being referenced as Bazecor.desktop when extracting the AppImage.
  3. python is being added a dependency.

Details

  1. mksquashfs will throw a error if both the SOURCE_DATE_EPOCH environment variable and the -all-time flag are set. This was happening since makepkg will set the SOURCE_DATE_EPOCH environment variable and @reforged/maker-appimage will always set the -all-time flag. This issue can be avoided by removing the SOURCE_DATE_EPOCH environment variable.

  2. In the AppImage it seems like bazecor.desktop is now Bazecor.desktop. I was getting a file not found error without this change.

squashfs-root/usr/share/icons
squashfs-root/usr/share/icons/hicolor
squashfs-root/usr/share/icons/hicolor/256x256
squashfs-root/usr/share/icons/hicolor/256x256/bazecor.png
sed: can't read squashfs-root/bazecor.desktop: No such file or directory
  1. I tested the PKGBUILD in a clean chroot and found that it failed without python since node-gyp is in the dependency chain for Bazecor and it requires python. Without python node-gyp will throw an error saying it cannot find python.
[STARTED] Running generateAssets hook
[SUCCESS] Running generateAssets hook
[STARTED] Running prePackage hook
[STARTED] [plugin-webpack] Preparing native dependencies
[TITLE] [plugin-webpack] Preparing native dependencies
[TITLE] [plugin-webpack] Preparing native dependencies: 0 / 1
[DATA] Error: Could not find any Python installation to use
[DATA]     at PythonFinder.fail (/build/bazecor-git/src/bazecor-git/node_modules/node-gyp/lib/find-python.js:330:47)
[DATA]     at PythonFinder.runChecks (/build/bazecor-git/src/bazecor-git/node_modules/node-gyp/lib/find-python.js:159:21)
[DATA]     at PythonFinder.<anonymous> (/build/bazecor-git/src/bazecor-git/node_modules/node-gyp/lib/find-python.js:202:16)
[DATA]     at PythonFinder.execFileCallback (/build/bazecor-git/src/bazecor-git/node_modules/node-gyp/lib/find-python.js:294:16)
[DATA]     at exithandler (node:child_process:430:5)
[DATA]     at ChildProcess.errorhandler (node:child_process:442:5)
[DATA]     at ChildProcess.emit (node:events:517:28)
[DATA]     at ChildProcess._handle.onexit (node:internal/child_process:290:12)
[DATA]     at onErrorNT (node:internal/child_process:477:16)
[DATA]     at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
[DATA] 
[DATA] 
[FAILED] node-gyp failed to rebuild '/build/bazecor-git/src/bazecor-git/node_modules/@serialport/bindings-cpp'
[FAILED] node-gyp failed to rebuild '/build/bazecor-git/src/bazecor-git/node_modules/@serialport/bindings-cpp'
[FAILED] node-gyp failed to rebuild '/build/bazecor-git/src/bazecor-git/node_modules/@serialport/bindings-cpp'
[FAILED] node-gyp failed to rebuild '/build/bazecor-git/src/bazecor-git/node_modules/@serialport/bindings-cpp'

Testing Evidence

As mentioned before, I tested the PKGBUILD in a clean chroot. I was able to install the package created using the command

sudo pacman -U bazecor-git-1.3.10_rc.3.3368-1-x86_64.pkg.tar.zst

terminal

bazecor-screenshot

@sagar794
Copy link
Author

Based on what changes are made to address the issue SpacingBat3/ReForged#13 and when Bazecor starts using that version of @reforged/maker-appimage, it might be a good idea to remove the line that is removing the SOURCE_DATE_EPOCH environment variable in PKGBUILD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant