Highlight key being pressed when not in mapping mode #6

Timecraft · 2020-02-27T21:09:30Z

Another thing is that in Games we use the same view for testing gamepad by highlighing a key when you press it if you're not in mapping mode. That could be handy here as well.

Originally posted by @Exalm in #4 (comment)

alice-mkh · 2020-02-27T21:28:29Z

Note that you can't do the "have an svg for every key" trick here, as you can press multiple keys at once. :p

alice-mkh · 2020-02-27T21:29:46Z

in Games we use a drawing area + render the svg via librsvg. First just render it, then for every pressed button { take its corresponding svg element, and render it masking with another color }.

Timecraft · 2020-02-27T21:46:54Z

Note that you can't do the "have an svg for every key" trick here, as you can press multiple keys at once. :p

Yeah, that makes it quite a bit more difficult

Timecraft · 2020-02-27T21:48:48Z

in Games we use a drawing area + render the svg via librsvg. First just render it, then for every pressed button { take its corresponding svg element, and render it masking with another color }.

I noticed that there was only one gamepad SVG file in Games. Wasn’t sure how you guys worked with it to highlight buttons. I’ve seen librsvg on the valadoc website, but haven’t gotten an excuse to really look into it. Now I do!

Timecraft · 2020-03-03T21:44:58Z

This is mostly working as of right now. Issues being seen:

No directions on analog sticks (don't know how to do that properly)
Trying to trigger/show ABS_X or ABS_RY does not work
Pressing "Home" triggers ABS_X
Using ABS_RY triggers "Home"
Using ABS_RX triggers ABS_RY
Using ABS_Y triggers ABS_RX
Using ABS_X triggers ABS_Y

alice-mkh · 2020-03-03T22:27:16Z

No directions on analog sticks (don't know how to do that properly)

You could e.g. show a circle with an offset matching the position. Games simply highlights the sides, like here:

Other things are probably you messing up ids, it's way too specific :p

alice-mkh · 2020-03-03T22:28:34Z

HighlightId button_middle_right = {"#button_middle_right" , false}; // Select

Typo: // Start

Timecraft · 2020-03-03T22:33:00Z

Typo: // Start

Whoops!

alice-mkh · 2020-03-03T22:35:56Z

So, why analogs are not working well:

highlight ({ EventCode.EV_ABS, axis }, !(-0.8 < value < 0.8))

What if X axis changed to 0.9 and then Y axis changed to 0.1? highlight (..., false);!

You should either track status of both or change how it's displayed not to use the same element.

alice-mkh · 2020-03-03T22:37:06Z

But given you already have a circle when mapping, I'd suggest to move it around according to the axis position and make it red when you press it.

alice-mkh · 2020-03-03T22:42:31Z

Also, highlight() has a completely unnecessary O(N) loop, though I suppose Games does this too right now. 😬️

And read_svg() is unused and probably can be simplified (I recently discovered you can cast bytes to a string, but here you should probably just load from resource directly)

Timecraft · 2020-03-03T22:44:56Z

Other things are probably you messing up ids, it's way too specific :p

I don't think so. I'm looking at the SVG Id's and the order of the HighlightId's, and they match.

HighlightId	INPUT_SOURCES
button_east	{ { EventCode.EV_KEY, EventCode.BTN_B }, "a" },
button_south	{ { EventCode.EV_KEY, EventCode.BTN_A }, "b" },
button_north	{ { EventCode.EV_KEY, EventCode.BTN_X }, "x"},
button_west	{ { EventCode.EV_KEY, EventCode.BTN_Y }, "y" },
dpad_up	{ { EventCode.EV_KEY, EventCode.BTN_DPAD_UP }, "dpup" },
dpad_down	{ { EventCode.EV_KEY, EventCode.BTN_DPAD_DOWN }, "dpdown" },
dpad_left	{ { EventCode.EV_KEY, EventCode.BTN_DPAD_LEFT }, "dpleft" },
dpad_right	{ { EventCode.EV_KEY, EventCode.BTN_DPAD_RIGHT }, "dpright" },
left_bumper	{ { EventCode.EV_KEY, EventCode.BTN_TL }, "leftshoulder" },
left_trigger	{ { EventCode.EV_KEY, EventCode.BTN_TL2 }, "lefttrigger" },
left_stick	{ { EventCode.EV_KEY, EventCode.BTN_THUMBL }, "leftstick" },
button_middle_left	{ { EventCode.EV_KEY, EventCode.BTN_SELECT }, "back" },
right_bumper	{ { EventCode.EV_KEY, EventCode.BTN_TR }, "rightshoulder" },
right_trigger	{ { EventCode.EV_KEY, EventCode.BTN_TR2 }, "righttrigger" },
right_stick	{ { EventCode.EV_KEY, EventCode.BTN_THUMBR }, "rightstick" },
button_middle_right	{ { EventCode.EV_KEY, EventCode.BTN_START }, "start" },
button_middle	{ { EventCode.EV_KEY, EventCode.BTN_MODE }, "guide" },
stick_left_analog	{ { EventCode.EV_ABS, EventCode.ABS_X }, "leftx" },
stick_left_analog	{ { EventCode.EV_ABS, EventCode.ABS_Y }, "lefty" },
stick_right_analog	{ { EventCode.EV_ABS, EventCode.ABS_RX }, "rightx" },
stick_right_analog	{ { EventCode.EV_ABS, EventCode.ABS_RY }, "righty" },

alice-mkh · 2020-03-03T22:45:08Z

Do you seriously have a button that says "Press Escape" and can't be clicked? 🤣️

The reason home button is not working is because it's not mapped correctly.

Timecraft · 2020-03-03T22:45:31Z

And read_svg() is unused

Hence why it's commented out. I should remove that, though

Timecraft · 2020-03-03T22:45:49Z

Do you seriously have a button that says "Press Escape" and can't be clicked? 🤣

...It can't be clicked?

alice-mkh · 2020-03-03T22:46:08Z

Wait, it can? Then there's a bug somewhere.

Timecraft · 2020-03-03T22:46:13Z

...It can't be clicked?

The button can be clicked

alice-mkh · 2020-03-03T22:47:06Z

Aha, if you try to set up a controller again without closing the window, it doesn't work.

alice-mkh · 2020-03-03T22:47:57Z

And I can't figure out how to map analog sticks, or it's bugged.

alice-mkh · 2020-03-03T22:48:53Z

The reason home button is not working is because it's not mapped correctly.

Checked with a mapping from Games, that's what it is indeed.

Timecraft · 2020-03-03T22:49:15Z

And I can't figure out how to map analog sticks, or it's bugged.

If you're referring to it not showing you which direction to go, yeah, that's what I was meaning:

No directions on analog sticks (don't know how to do that properly)

Timecraft · 2020-03-03T22:49:35Z

Checked with a mapping from Games, that's what it is indeed.

This is a me issue?

Timecraft · 2020-03-03T22:50:44Z

But given you already have a circle when mapping, I'd suggest to move it around according to the axis position and make it red when you press it.

This is kinda what I was meaning when I was saying "I don't know how to do that properly." I'm not sure how to move that.

alice-mkh · 2020-03-03T22:50:58Z

No directions on analog sticks (don't know how to do that properly)

Ah, ok.

Well, the easiest way is to split the stick indicators into 2, one for vertical and one for horizontal. But I think it would be better to move a circle.

alice-mkh · 2020-03-03T22:51:14Z

I'm not sure how to move that.

cr.translate()?

Timecraft · 2020-03-03T22:51:43Z

cr.translate()?

Would that not translate the entire context?

alice-mkh · 2020-03-03T22:51:46Z

This is a me issue?

Yes. I mean it's working with a mapping produced in Games, so you don't produce a correct mapping. :)

Timecraft · 2020-03-03T22:52:15Z

Yes. I mean it's working with a mapping produced in Games, so you don't produce a correct mapping. :)

Oh fun. I'll have to see what's going on there, then

alice-mkh · 2020-03-03T22:52:22Z

Would that not translate the entire context?

cr.push ();
cr.translate (...);
...
cr.pop ();

alice-mkh · 2020-03-03T22:53:26Z

Would that not translate the entire context?
cr.push ();
cr.translate (...);
...
cr.pop ();

Actually not even that. You already have push_group(), so it should just work for you if you translate between that and pop_group().

Timecraft · 2020-03-03T22:53:27Z

cr.push ();
cr.translate (...);
...
cr.pop ();

Oh, duh. That's the reason why it doesn't make the entire thing red 🤦‍♂️

Timecraft · 2020-03-03T22:54:08Z

.... oooooooooooooooh.....
Because I set mode last

Timecraft · 2020-03-03T23:14:15Z

For my own notes:

Home is triggering ABS_X due to Home being mapped after it should be.
- Fixing this should fix the rest of the axis issues.
To show the analog directions, translate that context between push_group () and pop_group ()

Timecraft · 2020-03-03T23:14:36Z

Once I get that last part done, I should be able to remove all of those extra SVG files too!

alice-mkh · 2020-03-03T23:54:39Z

I opened an issue to do the translation part in Games too, what we do currently is pretty lame.

Timecraft · 2020-03-04T15:02:46Z

Think I've got this done. It's a little weird, as it shows a stick for each axis, but it works

alice-mkh · 2020-03-04T15:18:45Z

See https://gitlab.gnome.org/GNOME/gnome-games/-/merge_requests/367 :)

Timecraft · 2020-03-04T15:55:18Z

It's hard for me to reimplement your code since I don't implement GamepadViewConfiguration, and therefore to not have access to configuration.analog_paths

Timecraft · 2020-03-04T15:55:34Z

Reopening this because those analog sticks are still way off

alice-mkh · 2020-03-04T15:56:12Z

Well, analog_paths are added in that MR in the first place. Just showing that it can be done really.

Timecraft · 2020-03-04T16:02:03Z

The earlier version I had (Where I was treating each analog direction independently) was fairly accurate, so I tried to use the offsets those were giving me to create an X and Y offset to make it more reflective of where the actual analog stick was. That created inaccuracies (pushing the analog stick directly left would not put the on-screen stick directly left)

Timecraft · 2020-03-04T16:02:38Z

No clue why if only one axis active it still shows the white circle in the middle, though

alice-mkh · 2020-03-04T16:03:37Z

(pushing the analog stick directly left would not put the on-screen stick directly left)

🤣️

You are supposed to use those X and Y offsets directly, yes.

Timecraft · 2020-03-04T16:24:16Z

The current iteration tried to do things more efficiently, but ends up doing the same thing as the version where they are being dealt with independently. I think it has to do with:

        HighlightId stick_left_analog_x     =             {"#stick_left_analog"   ,       false, Direction.X, 0, 0}; // Left Analog Stick
        HighlightId stick_left_analog_y     =             {"#stick_left_analog"   ,       false, Direction.Y, 0, 0}; // Left Analog Stick
        HighlightId stick_right_analog_x    =             {"#stick_right_analog"  ,       false, Direction.X, 0, 0}; // Right Analog Stick
        HighlightId stick_right_analog_y    =             {"#stick_right_analog"  ,       false, Direction.Y, 0, 0}; // Right Analog Stick

I'm currently dealing with the analogs' x and y separately. However, if I simply comment out those regions, it doesn't help. I think there will need to be some refactoring of the code to get this to work right

alice-mkh · 2020-03-04T16:43:49Z

Well yh, I did refactor my code a lot to do that.

Timecraft · 2020-03-04T23:46:47Z

Yeah, I feel like I'm going to just end up completely rewriting control_view.vala and control_window.vala to clean it up and try to fix #6, #9, #10, #11, #13, and #14

Timecraft added enhancement New feature or request help wanted Extra attention is needed labels Feb 27, 2020

Timecraft closed this as completed Mar 4, 2020

Timecraft reopened this Mar 4, 2020

Highlight key being pressed when not in mapping mode #6

Highlight key being pressed when not in mapping mode #6

Comments

Timecraft commented Feb 27, 2020 • edited Loading

alice-mkh commented Feb 27, 2020

alice-mkh commented Feb 27, 2020

Timecraft commented Feb 27, 2020

Timecraft commented Feb 27, 2020

Timecraft commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

Timecraft commented Mar 3, 2020

alice-mkh commented Mar 3, 2020 • edited Loading

alice-mkh commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

Timecraft commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

Timecraft commented Mar 3, 2020

Timecraft commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

Timecraft commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

Timecraft commented Mar 3, 2020

Timecraft commented Mar 3, 2020

Timecraft commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

Timecraft commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

Timecraft commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

Timecraft commented Mar 3, 2020

Timecraft commented Mar 3, 2020 • edited Loading

Timecraft commented Mar 3, 2020

Timecraft commented Mar 3, 2020

alice-mkh commented Mar 3, 2020

Timecraft commented Mar 4, 2020

alice-mkh commented Mar 4, 2020

Timecraft commented Mar 4, 2020

Timecraft commented Mar 4, 2020

alice-mkh commented Mar 4, 2020

Timecraft commented Mar 4, 2020

Timecraft commented Mar 4, 2020

alice-mkh commented Mar 4, 2020

Timecraft commented Mar 4, 2020

alice-mkh commented Mar 4, 2020

Timecraft commented Mar 4, 2020

Timecraft commented Feb 27, 2020 •

edited

Loading

alice-mkh commented Mar 3, 2020 •

edited

Loading

Timecraft commented Mar 3, 2020 •

edited

Loading