Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support unassigned elements for list variables #573

Merged
merged 39 commits into from Feb 22, 2024

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Jan 16, 2024

  • Nearby selection.
  • ifExists / ifNotExists rename and deprecation.
  • Cleanup broken quickstart tests.
  • Migration recipe.
  • Performance.
  • Get feedback from Orbit.

Counterparts PRs:
https://github.com/TimefoldAI/timefold-solver-enterprise/pull/84
TimefoldAI/timefold-quickstarts#285

Copy link
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished initial review. Comments inline.

Copy link
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a potential bug in VariableChangeRecordingScoreDirector for atypical before/after calls that we either want to document or pay a small performance penalty to fix. Pending new and original review comments, changes look good to me.

Copy link
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any blockers (provided the comment in the EntityOrderInfo is true). Some comments inline. LGTM.

triceo and others added 7 commits February 20, 2024 20:44
… that supports pinning

Currently, doing an update on a value with a null inverse relation
variable but is assigned to an entity causes an IllegalStateException
to be thrown in a forEach node, even if only shadow variables are
updated. It requires the model to supports pinning, since it is
caused by a branch that is only triggered if the model supports
pinning.
@triceo triceo linked an issue Feb 22, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Feb 22, 2024

@triceo triceo merged commit a0ce0e2 into TimefoldAI:main Feb 22, 2024
11 checks passed
@triceo triceo deleted the nullable branch February 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants