Skip to content

Commit

Permalink
more informative name
Browse files Browse the repository at this point in the history
  • Loading branch information
frankmcsherry committed Sep 6, 2019
1 parent ad57ea9 commit cfc0053
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
2 changes: 0 additions & 2 deletions src/logging.rs
Expand Up @@ -84,8 +84,6 @@ pub struct MergeShortfall {

impl From<MergeShortfall> for DifferentialEvent { fn from(e: MergeShortfall) -> Self { DifferentialEvent::MergeShortfall(e) } }



/// Either the start or end of a merge event.
#[derive(Debug, Clone, Abomonation, Ord, PartialOrd, Eq, PartialEq)]
pub struct TraceShare {
Expand Down
14 changes: 7 additions & 7 deletions src/operators/arrange/agent.rs
Expand Up @@ -37,7 +37,7 @@ where
advance: Vec<Tr::Time>,
through: Vec<Tr::Time>,

info: ::timely::dataflow::operators::generic::OperatorInfo,
operator: ::timely::dataflow::operators::generic::OperatorInfo,
logging: Option<::logging::Logger>,
}

Expand Down Expand Up @@ -82,7 +82,7 @@ where
Tr::Time: Timestamp+Lattice,
{
/// Creates a new agent from a trace reader.
pub fn new(trace: Tr, info: ::timely::dataflow::operators::generic::OperatorInfo, logging: Option<::logging::Logger>) -> (Self, TraceWriter<Tr>)
pub fn new(trace: Tr, operator: ::timely::dataflow::operators::generic::OperatorInfo, logging: Option<::logging::Logger>) -> (Self, TraceWriter<Tr>)
where
Tr: Trace,
Tr::Batch: Batch<Tr::Key,Tr::Val,Tr::Time,Tr::R>,
Expand All @@ -92,7 +92,7 @@ where

if let Some(logging) = &logging {
logging.log(
::logging::TraceShare { operator: info.global_id, diff: 1 }
::logging::TraceShare { operator: operator.global_id, diff: 1 }
);
}

Expand All @@ -101,7 +101,7 @@ where
queues: Rc::downgrade(&queues),
advance: trace.borrow().advance_frontiers.frontier().to_vec(),
through: trace.borrow().through_frontiers.frontier().to_vec(),
info,
operator,
logging,
};

Expand Down Expand Up @@ -524,7 +524,7 @@ where

if let Some(logging) = &self.logging {
logging.log(
::logging::TraceShare { operator: self.info.global_id, diff: 1 }
::logging::TraceShare { operator: self.operator.global_id, diff: 1 }
);
}

Expand All @@ -537,7 +537,7 @@ where
queues: self.queues.clone(),
advance: self.advance.clone(),
through: self.through.clone(),
info: self.info.clone(),
operator: self.operator.clone(),
logging: self.logging.clone(),
}
}
Expand All @@ -554,7 +554,7 @@ where

if let Some(logging) = &self.logging {
logging.log(
::logging::TraceShare { operator: self.info.global_id, diff: -1 }
::logging::TraceShare { operator: self.operator.global_id, diff: -1 }
);
}

Expand Down

0 comments on commit cfc0053

Please sign in to comment.