Batch arrange #27
Merged
Batch arrange #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things, including some fairly serious business changes to the
Tracetraits.The original intent was to allow
arrangeto accept batches of inputs, allowing us to re-use these batches in the sorting process. This thread lead to several other changes, including a refactoring of the existing trace implementations into commonSpineandBatchergeneric implementations, and much simplerHashValandHashKeyimplementations inimplementations/hash.rs. This unification should simplify maintaining all of these implementations.Testing these changes revealed a bug in
join, issue #26, which was fixed up by extendingTrace's methodcursorto take a frontier, and only iterate over updates that are not in the future of this frontier. This makesjoinmore correct, and has the potential to improvegroup's implementation in the future. In the meantime,join's implementation is much simpler, and transiently more correct.