Merge pull request openshift#18 from bipuladh/no-data-state

Show proper error message in Performance Card when no storage systems are present
TimothyAsirJeyasing · Aug 30, 2021 · d59888a · d59888a
2 parents e8b8bf3 + 405f97d
commit d59888a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/components/odf-dashboard/performance-card/performance-card.scss b/src/components/odf-dashboard/performance-card/performance-card.scss
@@ -22,7 +22,7 @@
   &--error {
     align-items: center;
     display: flex;
-    min-height: 30px;
+    min-height: 150px;
     place-content: center;
   }
 

diff --git a/src/components/odf-dashboard/performance-card/performance-card.tsx b/src/components/odf-dashboard/performance-card/performance-card.tsx
@@ -149,11 +149,12 @@ const PerformanceCard: React.FC = () => {
         />
       )}
       {loading && <PerformanceCardLoading />}
-      {error && !loading && (
-        <div className="odf-performanceCardError">
-          <DataUnavailableError />{' '}
-        </div>
-      )}
+      {(error && !loading) ||
+        (_.isEmpty(rawRows) && (
+          <div className="performanceCard--error">
+            <DataUnavailableError />{' '}
+          </div>
+        ))}
     </DashboardCard>
   );
 };