Add from_pem_private_key/from_pem_public_key methods
#109
Conversation
pycose/keys/cosekey.py
Outdated
| :return: An initialized COSE Key object. | ||
| """ | ||
|
|
||
| for key_type in cls._key_types.values(): |
There was a problem hiding this comment.
Iterating over _key_types is not wrong, but I find it a bit weird, especially considering that _key_types actually have three entries per key-type. On the other hand I'm not sure I can think of a much cleaner solution other than having just a list of key types? Or a separate map from cryptography types to pycose types. None of these are particularly elegant either, so maybe it's fine to keep this as is.
|
We also discussed offline whether accepting objects from the |
letmaik
changed the title
from_cryptography_key methodfrom_pem_private_key/from_pem_public_key methods
|
I've switched over to accepting PEM as key format as that is more universal and avoids forcing a specific crypto library. |
|
Kudos, SonarCloud Quality Gate passed!
|
1 similar comment
|
Kudos, SonarCloud Quality Gate passed!
|
Co-authored-by: Paul Liétar <lietarp@gmail.com>
TimothyClaeys
force-pushed
the
letmaik/cryptography-interop
branch
from
38313d8
to
b9b8f22
Compare
|
Addresses one half of #44.
Note on tests: The existing tests are a bit inconsistent between key types and I didn't want to change that in this PR which is why the new tests keep the existing style within each test file but may look a bit odd as a set.