Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimVer 0.8.5 - Installer issue #23

Closed
1 task done
bovirus opened this issue Jan 7, 2024 · 4 comments
Closed
1 task done

TimVer 0.8.5 - Installer issue #23

bovirus opened this issue Jan 7, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@bovirus
Copy link
Collaborator

bovirus commented Jan 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened or didn't happen

@Timthreetwelve m

The accented letters are now sown right.

Please check screenshot.

image

You have two instalerl (x64 and x64).
I beleive that is important show in window caption version and platform for the installer.

I bleieve that it's important toi add the info about requirement in otehr place and dsiable first window.
In this way it's possible toi add version/platform on window caption on top left.

No automatic language detect

At first run teh progranm didn't detect OS langauge and start always in English.
I propsoe you to detect at first run detection of OS language and set program language.

GUI Issues

image

GUI require a scroll on right.
Please increase right panel width

image

GUI require a scroll on bottom and right.
Please increase right panel width/height

I beleiev that coukld be better to set by default a right panel with more height/width

image

What's "Videcontroller1"?

Steps To Reproduce

Run the installer

Version

0.8.5

Windows Version

Windows 10 22 H2 64 bit italian

Relevant log output

No response

Anything else?

No response

@bovirus bovirus added bug Something isn't working needs triage This issue needs triage labels Jan 7, 2024
@Timthreetwelve Timthreetwelve removed the needs triage This issue needs triage label Jan 11, 2024
Timthreetwelve added a commit that referenced this issue Jan 11, 2024
@Timthreetwelve
Copy link
Owner

@bovirus

To address the size issues, I've updated the minimum window size and the default size when first installed. After the first run the app remembers it's size.

To address the installer issues, I made several changes.

The improperly displayed characters we due to file encoding. 🤦🏻

In TimVerLocaization.iss, in the [Messages] section, the custom messages for WelcomeLabel2 were removed.

Three new messages per language in the [CustomMessages] section have been added. There are three to allow customization for each of the three types of installation. These messages effectively replace the WelcomeLabel2 messages.

In TimVerEx.iss a new InitializeWizard procedure was added to the [Code] section. This procedure will use the InstallType constant, that is created during the publishing process, to insert the proper message back into WelcomeLabel2.

Finally, in TimVerLocalization.iss [Messages] section, new messages were added to put the version number into the installer windows title bar.

If you would, please verify the [Messages] section and add the appropriate translations to the [CustomMessages] section.

Screenshots showing different messages based on installer type.

TimVer_0 8 6 8_SC_x64_Setup tmp_2024-01-10_19-54-19

TimVer_0 8 6 8_x64x86_Setup tmp_2024-01-10_19-51-43

If the installer changes don't have any issues, I will bring them over to WUView, GetMyIP, etc.

FYI, this weekend is my mother's 100th birthday!🎉 I will be busy with out-of-town family and won't be able to spend much time on my projects.

Tim

@Timthreetwelve
Copy link
Owner

And "VideoController1" is the system assigned device ID.

@bovirus
Copy link
Collaborator Author

bovirus commented Jan 11, 2024

@Timthreetwelve

I updated the instalelr sstring for italian.
I change the order of spanish string to copy the order of english strings.

I porpose to change string like

click xxx

in

click 'xxx'

to highlight that you should select a button.

Thanks.

Timthreetwelve added a commit that referenced this issue Jan 19, 2024
@Timthreetwelve
Copy link
Owner

Version 0.8.100 has been released with fixes.

Thanks,
Tim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants