-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrong count/total #1
Comments
Sometimes count for 'all' is correct (compared with Tab Tally) but here it's way off: Is that the known limitation?
After pulling three other counters into the mix, adding a third tab to a window where the first tab was pinned, Sum Tabs counted only two of the three: |
Oops, apparently I'm not watching my own repository. That's kinda unfortunate. In my limited testing when I created the extension, I could not find broken cases. I definitely believe that there are situations that I haven't covered, though. If you could provide clear steps to reproduce on a clean profile with only my add-on (steps can include installing another add-on if that's the cause), that would greatly help me find the issue. |
I aimed to use a session file from my everyday profile, with a clean profile, but with Mozilla's Instead, I used a clean profile with Sum Tabs alongside one other extension, which allows a more flexible approach to session management: Session Manager. I opened a Also in that screenshot, the count for the current window (33) is probably wrong. My recollection (from use of the everyday profile) was that the window contained more than two hundred tabs. Subsequent use of the everyday profile confirms that – here, 206: – that number presented by Clear Tabs. Plus, the small size of the scroller in the sidebar view of Tab Center Redux suggests a long list, of more than 33 items. |
I found that my add-on is counting one tab too many per window. I think that something actually changed in Firefox, because I can easily reproduce it, and this definitely was not an issue before. With regard to the other issue (being off by a few hundred), I expect that it is counting tabs before all windows have opened. I never tried with more than two or three windows open, but I imagine it can be an issue when you have over a dozen in your session restore. I'll see if I can delay initialization. |
This impossible situation seems to be a conflict with some other plugins that open their own window(s).
In my situation DTA seems to be the culprit (when the DTA window is opened) as the total count was corrected when I've closed its window (but as DTA is not and will not be compatible with WebExtensions, it is maybe not revelant).
The text was updated successfully, but these errors were encountered: