Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added os listdir and scandir functions with their corresponding tests #143

Merged
merged 3 commits into from Sep 1, 2022

Conversation

santigandolfo
Copy link
Contributor

No description provided.

@santigandolfo santigandolfo changed the title Added os listdir function with it's tests Added os listdir and scandir functions with their corresponding tests Sep 1, 2022
@Tinche
Copy link
Owner

Tinche commented Sep 1, 2022

LGTM. Add it to the changelog please.

@santigandolfo
Copy link
Contributor Author

Great! Which version should I use? (I see that there is a v0.9.0 but it's TBD)

@Tinche
Copy link
Owner

Tinche commented Sep 1, 2022

Yeah, put it under 0.9.0.

@codecov-commenter
Copy link

Codecov Report

Base: 89.80% // Head: 89.86% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (1db5e4e) compared to base (d794675).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 1db5e4e differs from pull request most recent head 557de73. Consider uploading reports for the commit 557de73 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   89.80%   89.86%   +0.06%     
==========================================
  Files          10       10              
  Lines         304      306       +2     
==========================================
+ Hits          273      275       +2     
  Misses         31       31              
Impacted Files Coverage Δ
src/aiofiles/os.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tinche
Copy link
Owner

Tinche commented Sep 1, 2022

Thanks!

@Tinche Tinche merged commit 7636eff into Tinche:master Sep 1, 2022
@santigandolfo santigandolfo deleted the add-os-listdir branch September 5, 2022 12:52
@skshetry
Copy link

skshetry commented Sep 26, 2022

Hi, what do you think of the async version of scandir that returns DirEntry which have async methods?
Similar to aiopath.scandir.scandir_async.

The usecase that I have is to make ls(detail=True) completely async.

EDIT: Although we may not want to use async or run in thread if the DirEntry is cached. Also see python-trio/trio#924. So most likely this is not going to be trivial. Sorry for the noise. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants