Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 remove required from input elements #72

Merged
merged 1 commit into from Aug 12, 2022

Conversation

thinkjrs
Copy link
Member

The new button inputs had the required attribute on them. This PR removes those so that upstream clients aren't required to implement additional detail input data management.

@thinkjrs thinkjrs self-assigned this Aug 12, 2022
@github-actions
Copy link

size-limit report 📦

Path Size
dist/promo-button.cjs.production.min.js 56.65 KB (+0.01% 🔺)
dist/promo-button.esm.js 59.13 KB (0%)

@thinkjrs thinkjrs merged commit d264087 into develop Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant