Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: compat with TypeScript 4.6+ #2542

Merged
merged 1 commit into from Aug 31, 2022
Merged

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 31, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode force-pushed the splincode/refactor/typescript branch 4 times, most recently from c9b4a89 to 6cc02d1 Compare August 31, 2022 13:21
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022

Visit the preview URL for this PR (updated for commit e8a6388):

https://taiga-ui--pr2542-splincode-refactor-t-e0q98npr.web.app

(expires Thu, 01 Sep 2022 15:00:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #2542 (824bbb0) into main (19ebd6f) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 824bbb0 differs from pull request most recent head e8a6388. Consider uploading reports for the commit e8a6388 to get more accurate results

@@           Coverage Diff           @@
##             main    #2542   +/-   ##
=======================================
  Coverage   56.63%   56.63%           
=======================================
  Files         954      954           
  Lines        9187     9187           
  Branches     1882     1883    +1     
=======================================
  Hits         5203     5203           
  Misses       3581     3581           
  Partials      403      403           
Flag Coverage Δ
addon-charts 73.64% <ø> (ø)
addon-doc 19.16% <0.00%> (ø)
addon-editor 28.82% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 62.84% <ø> (ø)
core 62.86% <ø> (ø)
kit 61.46% <ø> (ø)
summary 56.63% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ojects/addon-commerce/utils/get-currency-symbol.ts 24.00% <ø> (ø)
.../src/components/navigation/navigation.component.ts 4.34% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@splincode splincode force-pushed the splincode/refactor/typescript branch from 824bbb0 to e8a6388 Compare August 31, 2022 14:56
@splincode splincode merged commit cb0b466 into main Aug 31, 2022
@splincode splincode deleted the splincode/refactor/typescript branch August 31, 2022 15:08
@well-done-bot
Copy link

well-done-bot bot commented Aug 31, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants