Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): add routable dialog #3369

Merged
merged 4 commits into from Feb 21, 2023

Conversation

Reactiver
Copy link
Contributor

@Reactiver Reactiver commented Jan 5, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jan 5, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jan 5, 2023

BundleMon

Files updated (3)
Status Path Size Limits
demo/browser/main.(hash).js
337.9KB (+526B +0.15%) +10%
demo/browser/runtime.(hash).js
36.03KB (+285B +0.78%) +10%
demo/browser/vendor.(hash).js
204.23KB (+113B +0.05%) +10%
Unchanged files (2)
Status Path Size Limits
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

Total files change +924B +0.15%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.3MB (+9.7KB +0.41%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 67.91% // Head: 74.39% // Increases project coverage by +6.47% 🎉

Coverage data is based on head (bcd84e5) compared to base (d717e54).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3369      +/-   ##
==========================================
+ Coverage   67.91%   74.39%   +6.47%     
==========================================
  Files        1167      694     -473     
  Lines       14040     8610    -5430     
  Branches     1948     1297     -651     
==========================================
- Hits         9535     6405    -3130     
+ Misses       4172     1986    -2186     
+ Partials      333      219     -114     
Flag Coverage Δ
addon-charts ?
addon-doc ?
addon-editor ?
addon-mobile ?
addon-table ?
addon-tablebars ?
cdk ?
core 76.82% <ø> (ø)
kit 73.00% <100.00%> (+0.13%) ⬆️
summary 74.39% <100.00%> (+6.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/components/index.ts 100.00% <100.00%> (ø)
...nents/routable-dialog/generate-dialogable-route.ts 100.00% <100.00%> (ø)
projects/kit/components/routable-dialog/index.ts 100.00% <100.00%> (ø)
...nents/routable-dialog/routable-dialog.component.ts 100.00% <100.00%> (ø)
...mponents/routable-dialog/routable-dialog.module.ts 100.00% <100.00%> (ø)
...cts/addon-tablebars/services/table-bars.service.ts
...cts/addon-editor/extensions/group/group.options.ts
...near-multi-picker/linear-multi-picker.component.ts
projects/addon-commerce/components/card/index.ts
...don-charts/components/bar-set/bar-set.component.ts
... and 472 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Reactiver Reactiver force-pushed the feat/routable-dialog branch 4 times, most recently from 219ce04 to 32d6be9 Compare January 11, 2023 10:29
@Reactiver Reactiver force-pushed the feat/routable-dialog branch 3 times, most recently from d67f641 to dd026c9 Compare February 9, 2023 16:19
@Reactiver Reactiver changed the title [WIP] feat(kit): add routable dialog feat(kit): add routable dialog Feb 9, 2023
@Reactiver Reactiver marked this pull request as ready for review February 9, 2023 19:31
@Reactiver Reactiver force-pushed the feat/routable-dialog branch 2 times, most recently from 412964b to 546386a Compare February 13, 2023 14:46
@Reactiver Reactiver marked this pull request as draft February 17, 2023 08:32
@Reactiver Reactiver force-pushed the feat/routable-dialog branch 3 times, most recently from 84df153 to 4a7239d Compare February 17, 2023 14:54
@Reactiver Reactiver marked this pull request as ready for review February 17, 2023 15:00
@Reactiver Reactiver requested review from waterplea and removed request for splincode, vladimirpotekhin and nsbarsukov February 20, 2023 06:05
@waterplea waterplea merged commit daadcab into taiga-family:main Feb 21, 2023
@well-done-bot
Copy link

well-done-bot bot commented Feb 21, 2023

'Well done'

waterplea pushed a commit that referenced this pull request Feb 21, 2023
Co-authored-by: Dima Puris <d.puris@tinkoff.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants