ci: restrict console.log/debug in production code

.eslintrc.js

@@ -13,11 +13,13 @@ module.exports = {
         sourceType: 'module',
     },
     rules: {
+        // TODO: move rules to @tinkoff/eslint-config-angular
         '@typescript-eslint/no-useless-constructor': 'off',
         '@typescript-eslint/explicit-member-accessibility': [
             'error',
             {accessibility: 'no-public'},
         ],
         '@typescript-eslint/prefer-readonly': ['error'],
+        'no-console': ['error', {allow: ['info', 'assert', 'warn', 'error']}],
     },
 };

projects/addon-doc/src/components/documentation/documentation-property-connector.directive.ts

@@ -93,7 +93,7 @@ export class TuiDocDocumentationPropertyConnectorDirective<T>
 
     emitEvent(event: unknown): void {
         // For more convenient debugging
-        console.log(this.attrName, event);
+        console.info(this.attrName, event);
 
         this.emits$.next(this.emits$.value + 1);
     }

projects/demo/server.ts

@@ -65,7 +65,7 @@ function run() {
     const server = app();
 
     server.listen(port, () => {
-        console.log(`Node Express server listening on http://localhost:${port}`);
+        console.info(`Node Express server listening on http://localhost:${port}`);
     });
 }
 

projects/demo/src/main.browser.ts

@@ -16,12 +16,12 @@ if (environment.hmr) {
         hmrBootstrap(module, bootstrap);
     } else {
         console.error('HMR is not enabled for webpack-dev-server!');
-        console.log('Are you using the --hmr flag for ng serve?');
+        console.info('Are you using the --hmr flag for ng serve?');
     }
 } else {
     document.addEventListener('DOMContentLoaded', () => {
         setTimeout(() => {
-            bootstrap().catch(err => console.log(err));
+            bootstrap().catch(err => console.error(err));
         });
     });
 }

projects/demo/src/modules/components/button/examples/1/index.ts

@@ -14,6 +14,6 @@ export class TuiButtonExample1 {
     readonly avatarUrl = avatar;
 
     onClick(event: MouseEvent) {
-        console.log('click', event);
+        console.info('click', event);
     }
 }

projects/demo/src/modules/components/dialog/examples/2/index.ts

@@ -30,10 +30,10 @@ export class TuiDialogExampleComponent2 {
     showDialog() {
         this.dialog.subscribe({
             next: data => {
-                console.log('Dialog emitted data = ' + data);
+                console.info('Dialog emitted data = ' + data);
             },
             complete: () => {
-                console.log('Dialog closed');
+                console.info('Dialog closed');
             },
         });
     }

projects/demo/src/modules/components/link/examples/3/index.ts

@@ -11,6 +11,6 @@ import {encapsulation} from '@demo/emulate/encapsulation';
 })
 export class TuiLinkExample3 {
     onClick(event: MouseEvent) {
-        console.log('click', event);
+        console.info('click', event);
     }
 }

projects/demo/src/modules/components/pagination/examples/1/index.ts

@@ -16,6 +16,6 @@ export class TuiPaginationExample1 {
 
     goToPage(index: number) {
         this.index = index;
-        console.log('New page:', index);
+        console.info('New page:', index);
     }
 }

projects/demo/src/modules/components/preview/examples/1/index.ts

@@ -43,7 +43,7 @@ export class TuiPreviewExample1 {
 
     show() {
         this.previewService.open(this.preview || '').subscribe({
-            complete: () => console.log('complete'),
+            complete: () => console.info('complete'),
         });
     }
 

projects/demo/src/modules/components/preview/examples/3/index.ts

@@ -58,7 +58,7 @@ export class TuiPreviewExample3 {
     }
 
     download() {
-        console.log('downloading...');
+        console.info('downloading...');
     }
 
     emulateBackendRequest(): Observable<string> {

projects/demo/src/modules/components/primitive-textfield/primitive-textfield.component.ts

@@ -184,6 +184,6 @@ export class ExampleTuiPrimitiveTextfieldComponent extends AbstractExampleTuiInt
     }
 
     onClick() {
-        console.log('Interactive icon clicked');
+        console.info('Interactive icon clicked');
     }
 }

projects/demo/src/modules/directives/dropdown-context/examples/3/index.ts

@@ -16,6 +16,6 @@ export class TuiDropdownContextExample3 {
     });
 
     report() {
-        console.log(this.testForm.value);
+        console.info(this.testForm.value);
     }
 }

projects/demo/src/modules/directives/manual-hint/manual-hint.component.ts

@@ -33,6 +33,6 @@ export class ExampleTuiManualHintComponent extends AbstractExampleTuiHint {
     show = false;
 
     sayHi() {
-        console.log('Hi all!');
+        console.info('Hi all!');
     }
 }

projects/demo/src/modules/directives/swipe/examples/2/index.ts

@@ -19,7 +19,7 @@ export class TuiSwipeExample2 {
     }
 
     onSwipe(swipe: TuiSwipe) {
-        console.log(swipe.direction);
+        console.info(swipe.direction);
 
         if (swipe.direction === 'left') {
             this.toggle(true);

projects/demo/src/modules/services/destroy/examples/1/component.ts

@@ -16,8 +16,6 @@ export class TuiDestroyExample {
     constructor(destroy$: TuiDestroyService, {nativeElement}: ElementRef<HTMLElement>) {
         fromEvent(nativeElement, 'click')
             .pipe(takeUntil(destroy$))
-            .subscribe(() => {
-                console.log('click');
-            });
+            .subscribe(() => console.info('click'));
     }
 }

projects/demo/src/modules/tables/table/examples/4/index.ts

@@ -162,7 +162,7 @@ export class TuiTableExample4 {
         size: number,
         minAge: number,
     ): Observable<ReadonlyArray<User | null>> {
-        console.log('Making a request');
+        console.info('Making a request');
 
         const start = page * size;
         const end = start + size;

scripts/release.js

@@ -47,7 +47,7 @@ function checkChangelog() {
 
     readline.setPrompt(`Check\n./CHANGELOG.md\nand save all fixes. Then press enter`);
     readline.prompt();
-    console.log('\n');
+    console.info('\n');
 
     return new Promise(resolve => {
         readline.on('line', userInput => {