chore(cdk): TuiDay improvement of localization
#1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsbarsukov
requested review from
MarsiBarsi and
vladimirpotekhin
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
|
Visit the preview URL for this PR (updated for commit c03333e): https://taiga-ui--pr1139-tui-day-localization-tf8h1ybs.web.app (expires Thu, 23 Dec 2021 13:57:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
It is required for future feature #954 |
nsbarsukov
changed the title
TuiDay add static method parseRawDateStringTuiDay improvement of localization
| static parseRawDateString( | ||
| date: string, | ||
| dateMode: TuiDateMode = 'DMY', | ||
| ): {day: number; month: number; year: number} { |
There was a problem hiding this comment.
nit: maybe add assertion for invalid string?
vladimirpotekhin
approved these changes
Dec 22, 2021
splincode
approved these changes
Dec 22, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?