-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swig wrapper for cg-proc #37
Conversation
added: CG3:: before class names in Grammar.hpp pass arg -DENABLE_PYTHON_BINDINGS:BOOL=ON during cmake
did you modify the travis.yml to verify the python bindings build? (if needed) |
do you mean 26c166f#diff-354f30a63fb0907d4ad57269548329e3R14? |
@TinoDidriksen could you please take a look at this PR? |
The Grammar.hpp changes cannot possibly be necessary. It's in the CG3 namespace, and all headers it includes put their things in the CG3 namespace. It should not need qualification. Bumping CMake to 3.0 is fine. Only CentOS 7 needs special handling for that. Also note that CG-3 is not a git project - this is a read-only copy of the svn repo, so pushing changes are a bit more fiddly. |
|
That is rather bizarre. Surely |
Adding this before |
list being mutable can't be used as dictionary keys
@TinoDidriksen any further thoughts on |
Committed, without changing src/ |
…loses #37) git-svn-author: lokendras1998@gmail.com git-svn-id: svn+ssh://beta.visl.sdu.dk/usr/local/svn/repos/visl/tools/vislcg3/trunk@13554 cb2587b3-b7ff-0310-8c81-a2a651690ada
guarded by
ENABLE_PYTHON_BINDINGS
cmake
minimum version to3.0.2
for finding python interpreterGrammar.hpp
for including in swig wrapperxenial
Usage: